feat(compiler): Support subqueries in the FROM clause #3227
Conversation
Fixed resolving refs to CTEs by adding CTEs to the aliasMap and indexing its columns when resolving catalog references. Fix sqlc-dev#3219
issue sqlc-dev#2989, sqlc-dev#2400 and probably others
|
I've based this on #3220, so let's merge that first. |
|
(https://snoozeth.is/tnvQn2qtHWc) I will wait until #3220 is merged and then add a comment. |
This reverts commit 3f129e7.
|
I had to revert this PR as it was causing quite a few tests to fail. |
I don't quite understand the CI setup if the checks passed in the PR but failed after merge. Could you, if possible, re-run checks in #3220 and this PR separately to identify where the regression is. As I wrote in the issue related to #3220. I haven't had issues with the changeset to that PR. |
|
I was waiting for this PR, just downloaded version 1.26, mainly for #3219, but when it didn't worked I got here. Hope this can be solved, thanks to everyone for making sqlc great. |
|
This branch needs to be rebased on main. Once that happens, the failing tests will show up. |
|
https://github.com/sqlc-dev/sqlc/actions/runs/8534508908/job/23379055224?pr=3310 The failing tests are because @simonklee's PR was open for so long, there was a version bump in between (from 1.25 -> 1.26) which caused the tests to fail :( |
* fix(resolve): fix resolving reference to CTEs Fixed resolving refs to CTEs by adding CTEs to the aliasMap and indexing its columns when resolving catalog references. Fix sqlc-dev#3219 * feat(compiler): Support subqueries in the FROM clause issue sqlc-dev#2989, sqlc-dev#2400 and probably others --------- Co-authored-by: Simon Klee <hello@simonklee.dk>
…ev#3227)" (sqlc-dev#3299) This reverts commit 3f129e7.
issue #2989, #2400 and probably others