feat(compiler): Support subqueries in the FROM clause (second coming) #3310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed resolving refs to CTEs by adding CTEs to the aliasMap and indexing its columns when resolving catalog references. Fix sqlc-dev#3219
issue sqlc-dev#2989, sqlc-dev#2400 and probably others
|
Thanks for rebasing, @Jille. |
|
Merging this PR caused test failures again, but I now know why. On pull requests the tests aren't being correctly run using the database analyzer. Once I get that fixed the tests will correctly fail on this change. Sorry for all the back and forth here. |
|
Alright, @Jille want to try a third time? The database analyzer tests, which were failing, will now run on your PR. |
lisitsky
pushed a commit
to lisitsky/sqlc
that referenced
this pull request
Jun 21, 2024
…sqlc-dev#3310) * fix(resolve): fix resolving reference to CTEs Fixed resolving refs to CTEs by adding CTEs to the aliasMap and indexing its columns when resolving catalog references. Fix sqlc-dev#3219 * feat(compiler): Support subqueries in the FROM clause issue sqlc-dev#2989, sqlc-dev#2400 and probably others * chore(endtoend): Bump version in cte_resolve_ref to 1.26.0 to appease CI --------- Co-authored-by: Simon Klee <hello@simonklee.dk>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #2989, #2400 and probably others
This is the same as #3227, but rebased to main on Kyle's request.