Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated OpenJPEG struct member #978

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Remove deprecated OpenJPEG struct member #978

merged 1 commit into from
Oct 10, 2023

Conversation

kmilos
Copy link
Contributor

@kmilos kmilos commented Oct 10, 2023 •
edited
Loading

@farindk
Copy link
Contributor

farindk commented Oct 10, 2023

I now that bpp was marked as deprecated, but I intentionally left it in there in case an ancient version of OpenJPEG might need it. But probably, it can be removed.

@kmilos
Copy link
Contributor Author

kmilos commented Oct 10, 2023

in case an ancient version of OpenJPEG might need it. But probably, it can be removed.

Yeah, prec has been part of the API for years... If we go by the same logic as CMake min version, the OpenJPEG 2.3 in Ubuntu 20.04 is sure to have it, so it can be safely removed?

@farindk
Copy link
Contributor

farindk commented Oct 10, 2023

Right, makes sense.

@farindk farindk merged commit eb474cf into strukturag:master Oct 10, 2023
30 of 31 checks passed
@kmilos kmilos deleted the kmilos/remove_opj_bpp branch October 10, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecated features used in OpenJPEG codec
2 participants
@kmilos @farindk