API: deprecate 'bpp' member in favor of 'prec' #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rouault
force-pushed
the
deprecate_bpp
branch
from
ecca2f7
to
d4724d0
Compare
in opj_image_comp and opj_image_comptparm structures. bpp was redundant with prec, and almost never set by the library, except by opj_image_create(). This change should hopefully not impact existing, working, users of the API, which should already have used prec to get things working. Fixes uclouvain#1379
rouault
force-pushed
the
deprecate_bpp
branch
from
d4724d0
to
0b5d626
Compare
yes there might be people setting them, but that had no effect. |
intel-media-ci
pushed a commit
to intel-media-ci/gstreamer
that referenced
this pull request
May 26, 2023
It's deprecated in favor of the .prec field which we already set. uclouvain/openjpeg#1383 Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4715>
mengker33
pushed a commit
to mengker33/gstreamer
that referenced
this pull request
Aug 31, 2023
It's deprecated in favor of the .prec field which we already set. uclouvain/openjpeg#1383 Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4715>
kmilos
added a commit
to kmilos/libheif
that referenced
this pull request
Oct 10, 2023
thochstein
pushed a commit
to nxp-imx/gst-plugins-bad
that referenced
this pull request
Jun 17, 2024
It's deprecated in favor of the .prec field which we already set. uclouvain/openjpeg#1383 Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4715>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in opj_image_comp and opj_image_comptparm structures.
bpp was redundant with prec, and almost never set by the library, except
by opj_image_create(). This change should hopefully not impact existing,
working, users of the API, which should already have used prec to get
things working.
Fixes #1379