This repository has been archived by the owner on Mar 10, 2024. It is now read-only.
feat: support custom field create/update for salesforce, picklists for salesforce/hubspot #2041
+486
−182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasmarshall
requested review from
tomkit,
tonyxiao,
asdfryan and
george-xing
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lucasmarshall
commented
Dec 8, 2023
| @@ -137,7 +137,7 @@ app.use((err: unknown, req: Request, res: Response<{ errors: ResponseErrors }>, | |||
| return res.status(500).json({ | |||
| errors: [ | |||
| { | |||
| id: req.id.toString(), | |||
| id: req.id?.toString(), | |||
There was a problem hiding this comment.
Causes issues if the json in the request body is not parsable
lucasmarshall
commented
Dec 8, 2023
| /* prefixed */ true | ||
| ); | ||
|
|
||
| const result = await this.#client.tooling.create('CustomField', createParams); |
There was a problem hiding this comment.
We use the Salesforce Tooling API because that's what our customer uses. Using the jsforce metadata client and/or salesforce metadata API, there are some bugs. One of them is that setting a label for a picklist item doesn't work. This functionality is required by our customer, so we must use the Tooling API to support their use case correctly.
…r salesforce/hubspot
lucasmarshall
force-pushed
the
lucas/custom-fields
branch
from
44a0f4b
to
3d07ea0
Compare
lucasmarshall
commented
Dec 8, 2023
asdfryan
reviewed
Dec 11, 2023
asdfryan
approved these changes
Dec 11, 2023
asdfryan
reviewed
Dec 11, 2023
lucasmarshall
force-pushed
the
lucas/custom-fields
branch
from
e0673ce
to
37439e1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.