Deploy: host statics from tigris buckets #3864
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btoews
reviewed
Aug 19, 2024
alichay
force-pushed
the
feat/statics-to-tigris-bucket
branch
from
d5f4cdd
to
d5a7c5e
Compare
Untested. Does not configure service to host statics from tigris.
A lot of this will get reworked when virtual services land, this is a quick hack to get it demoable
This prevents leftover static files from a failed or aborted deploy, and cleans up statics *newer* than the current deploy (for the case that the user reuses an app name and the bucket wasn't deleted previously)
This is a partial commit of a larger change, so I haven't been able to test this yet :)
This is bucket names are ensured to be unique, but ext names are not. We need to use the BUCKET_NAME env var.
I was noticing that extension names aren't necessarily globally unique, which gets a little odd when you can access two extensions with the same name. This is a bandaid for the real problem, but lets this feature ship *now* :)
alichay
force-pushed
the
feat/statics-to-tigris-bucket
branch
from
cd31335
to
2567cf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
What and Why: This makes
fly deploysupport deploying static files to tigris buckets instead of using a web server integrated in the machine's init process. This makes everything a little more efficient, allows serving static files when machines are stopped, and paves the way for further improvements to statics. :)How: When deploying, if the app has static files defined, it will use (or create) a tigris bucket named after the app. Files are uploaded to this bucket, and a couple versions of file history are kept.
Related to: superfly/tokenizer#23
Depends on: superfly/fly-go#97
Documentation