Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support signing sigv4 requests #23

Merged
merged 8 commits into from
Aug 26, 2024
Merged

Support signing sigv4 requests #23

merged 8 commits into from
Aug 26, 2024

Conversation

alichay
Copy link
Contributor

@alichay alichay commented Aug 16, 2024

Allows signing Sigv4 requests (such as S3 requests).
Expects a "valid" sigv4 request in, but does not validate the access or secret keys (the only validation done is via tokenizer), it just extracts region, service, and the request timestamp from the "Authorization" header for its own signing.

Copy link
Member

@btoews btoews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this. It must have been a pain to reverse engineer these headers.

processor.go Show resolved Hide resolved
@btoews
Copy link
Member

btoews commented Aug 19, 2024

I deployed this branch to tokenizer.fly.io if that's helpful for testing your other changes.

Copy link
Member

@btoews btoews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alichay alichay marked this pull request as ready for review August 20, 2024 14:33
@alichay alichay merged commit a17a2e0 into main Aug 26, 2024
1 check passed
@alichay alichay deleted the feat/sigv4 branch August 26, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants