better error for unmatched closing tag (#321)

sveltejs · Mar 1, 2017 · 2efd532 · 2efd532
1 parent a8d1983
commit 2efd532
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 0 deletions.
diff --git a/src/parse/state/tag.js b/src/parse/state/tag.js
@@ -90,6 +90,8 @@ export default function tag ( parser ) {
 
 		// close any elements that don't have their own closing tags, e.g. <div><p></div>
 		while ( parent.name !== name ) {
+			if ( parent.type !== 'Element' ) parser.error( `</${name}> attempted to close an element that was not open`, start );
+
 			parent.end = start;
 			parser.stack.pop();
 

diff --git a/test/parser/error-unmatched-closing-tag/error.json b/test/parser/error-unmatched-closing-tag/error.json
@@ -0,0 +1,8 @@
+{
+	"message": "</div> attempted to close an element that was not open",
+	"loc": {
+		"line": 1,
+		"column": 0
+	},
+	"pos": 0
+}
diff --git a/test/parser/error-unmatched-closing-tag/input.html b/test/parser/error-unmatched-closing-tag/input.html
@@ -0,0 +1 @@
+</div>