Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compiling code with stray closing tag throws #321

Closed
Conduitry opened this issue Mar 1, 2017 · 2 comments
Closed

Compiling code with stray closing tag throws #321

Conduitry opened this issue Mar 1, 2017 · 2 comments

Comments

@Conduitry
Copy link
Member

Compiling code with a stray closing tag throws an error here as parent is undefined. This used to be more elegantly handled in 1.8.0.

REPL - 1.8.0 - 1.8.1

(I actually noticed this because in a project I had been using some (apparently!) bad markup, and had a <pre> element inside of a <p>. With 1.8.1, this now automatically closes the <p> when it reaches the <pre>, and then Svelte gets confused when it later hits the </p>.)
@Conduitry
Copy link
Member Author

Well maybe not that elegantly handled in 1.8.0 - REPL - if there's more text after the closing tag, there is still an exception thrown.

Rich-Harris added a commit that referenced this issue Mar 1, 2017
@Rich-Harris
better error for unmatched closing tag (#321)
2efd532
@Rich-Harris Rich-Harris mentioned this issue Mar 1, 2017
Merged
@Rich-Harris
Copy link
Member

Good catch, thanks — opened #323

Rich-Harris added a commit that referenced this issue Mar 1, 2017
@Rich-Harris
Merge pull request #323 from sveltejs/gh-321
0da2a99 
better error for unmatched closing tag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Rich-Harris @Conduitry