Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] a11y-no-redundant-roles #7067

Merged
merged 17 commits into from
Jan 3, 2022
Merged

[feat] a11y-no-redundant-roles #7067

merged 17 commits into from
Jan 3, 2022

Commits on Dec 27, 2021

  1. add a redundant roles compiler warning

    James Bradbury committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    373efcb View commit details
    Browse the repository at this point in the history

  2. add a test case for redundant roles

    James Bradbury committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    7eeca8e View commit details
    Browse the repository at this point in the history

  3. add validators for a11y-redundant-roles

    James Bradbury committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    f7bc2c7 View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2021

  1. add warnings to check against

    James Bradbury committed Dec 28, 2021
    Configuration menu
    Copy the full SHA
    6691748 View commit details
    Browse the repository at this point in the history

  2. remove code comments that are extraneous

    James Bradbury committed Dec 28, 2021
    Configuration menu
    Copy the full SHA
    12afce7 View commit details
    Browse the repository at this point in the history

  3. correct linting issues

    James Bradbury committed Dec 28, 2021
    Configuration menu
    Copy the full SHA
    30c0352 View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2021

  1. remove suggestion from compiler warning

    James Bradbury committed Dec 30, 2021
    Configuration menu
    Copy the full SHA
    db606c7 View commit details
    Browse the repository at this point in the history

  2. abstract parent element check into function

    James Bradbury committed Dec 30, 2021
    Configuration menu
    Copy the full SHA
    91ec3fc View commit details
    Browse the repository at this point in the history

  3. nest article/section checks into an if statement

    James Bradbury committed Dec 30, 2021
    Configuration menu
    Copy the full SHA
    53b8919 View commit details
    Browse the repository at this point in the history

  4. use else if where possible

    James Bradbury committed Dec 30, 2021
    Configuration menu
    Copy the full SHA
    17906c2 View commit details
    Browse the repository at this point in the history

  5. linting suggestions

    James Bradbury committed Dec 30, 2021
    Configuration menu
    Copy the full SHA
    649e462 View commit details
    Browse the repository at this point in the history

  6. update test to reflect unduplicated warnings

    James Bradbury committed Dec 30, 2021
    Configuration menu
    Copy the full SHA
    b6060f3 View commit details
    Browse the repository at this point in the history

  7. simplify conditional logic

    James Bradbury committed Dec 30, 2021
    Configuration menu
    Copy the full SHA
    bb975e7 View commit details
    Browse the repository at this point in the history

Commits on Dec 31, 2021

  1. include more conditions from PR sveltejs#5361

    James Bradbury committed Dec 31, 2021
    Configuration menu
    Copy the full SHA
    7c0b63f View commit details
    Browse the repository at this point in the history

  2. update test to reflect more cases that can be checked

    James Bradbury committed Dec 31, 2021
    Configuration menu
    Copy the full SHA
    fdfbbed View commit details
    Browse the repository at this point in the history

  3. move constants to top of file and rename with a11y prefix

    James Bradbury committed Dec 31, 2021
    Configuration menu
    Copy the full SHA
    2b05e54 View commit details
    Browse the repository at this point in the history

  4. remove case caught by (this.name === value)

    James Bradbury committed Dec 31, 2021
    Configuration menu
    Copy the full SHA
    6ab5c7f View commit details
    Browse the repository at this point in the history