Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: migrate unapproved stories #36

Merged
merged 1 commit into from
Aug 28, 2021
Merged

docs: migrate unapproved stories #36

merged 1 commit into from
Aug 28, 2021

Conversation

irmir
Copy link
Contributor

@irmir irmir commented Aug 22, 2021 •
edited
Loading

Migrate Button, ButtonGroup, Banner, Calendar (Month, Week, WeekHeader), InlineDialog, Item, ItemGroup, ModalDialog, Panel, ResizablePanel, PasswordField, Tabs, Textarea, TopNav.

closes #9

@irmir irmir added internal Changes only affect the internal API released This issue/pull request has been released. labels Aug 22, 2021
@github-actions
Copy link

github-actions bot commented Aug 22, 2021 •
edited
Loading

Unit Test Results

    1 files    28 suites   22s ⏱️
191 tests 191 ✔️ 0 💤 0 ❌

Results for commit 67c51a8.

♻️ This comment has been updated with latest results.

@irmir irmir force-pushed the fix-migrate-unapproved-stories branch from c905e6d to 574c2b9 Compare August 24, 2021 11:34
@gazpachu gazpachu removed the released This issue/pull request has been released. label Aug 25, 2021
@irmir irmir force-pushed the fix-migrate-unapproved-stories branch from bd53df9 to bf67d2f Compare August 25, 2021 08:18
gazpachu
gazpachu previously approved these changes Aug 25, 2021
View reviewed changes
@SimeonC
Copy link
Collaborator

SimeonC commented Aug 25, 2021

@irmir Please change completes in commit and description, it's not a GitHub keyword, see here for reference: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

@SimeonC SimeonC added documentation Changes only affect the documentation and removed internal Changes only affect the internal API labels Aug 25, 2021
SimeonC
SimeonC requested changes Aug 25, 2021
View reviewed changes
Copy link
Collaborator

@SimeonC SimeonC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chore: migrate unapproved stories isn't really descriptive of what's going on here. You have a mixture of fixes and documentation. Please separate out any stories that have internal changes to either types or functionality to separate Pull Requests. The commit message for here should be docs: migrate unapproved stories.

@irmir irmir force-pushed the fix-migrate-unapproved-stories branch 3 times, most recently from c68992d to 0b98d3e Compare August 25, 2021 13:39
@irmir irmir changed the title chore: migrate unapproved stories docs: migrate unapproved stories Aug 25, 2021
@SimeonC SimeonC mentioned this pull request Aug 26, 2021
Merged
@irmir irmir force-pushed the fix-migrate-unapproved-stories branch from 0b98d3e to fa541da Compare August 26, 2021 06:11
@irmir
docs: migrate unapproved stories
67c51a8 
Migrate Button, ButtonGroup, Calendar (Month, Week, WeekHeader), InlineDialog, Item, ItemGroup, ModalDialog, Panel, PasswordField, ResizablePanel, Tabs, Textarea, TopNav.

closes #9
@irmir irmir force-pushed the fix-migrate-unapproved-stories branch from fa541da to 67c51a8 Compare August 26, 2021 06:20
@gazpachu gazpachu merged commit 11ce022 into main Aug 28, 2021
@gazpachu gazpachu deleted the fix-migrate-unapproved-stories branch August 28, 2021 12:50
@tablecheck-public-automation
Copy link
Collaborator

🚀 PR was released in @tablecheck/tablekit-alert@1.0.1, @tablecheck/tablekit-avatar@1.0.1, @tablecheck/tablekit-badge@1.0.1, @tablecheck/tablekit-banner@1.0.1, @tablecheck/tablekit-button-group@1.0.1, @tablecheck/tablekit-button@1.0.1, @tablecheck/tablekit-calendar@1.0.1, @tablecheck/tablekit-checkbox@1.0.1, @tablecheck/tablekit-free-icon-config@1.0.1, @tablecheck/tablekit-icon@1.0.1, @tablecheck/tablekit-inline-dialog@1.0.1, @tablecheck/tablekit-input-button@1.0.2, @tablecheck/tablekit-input@1.0.1, @tablecheck/tablekit-item@1.0.1, @tablecheck/tablekit-language-selector@1.0.1, @tablecheck/tablekit-logo@1.0.1, @tablecheck/tablekit-modal-dialog@1.0.2, @tablecheck/tablekit-panel@1.0.1, @tablecheck/tablekit-password-field@1.0.1, @tablecheck/tablekit-phone-input@1.0.1, @tablecheck/tablekit-pro-icon-config@1.0.1, @tablecheck/tablekit-radio@1.0.1, @tablecheck/tablekit-select@1.0.1, @tablecheck/tablekit-sidenav@1.0.1, @tablecheck/tablekit-table@1.0.1, @tablecheck/tablekit-tabs@1.0.1, @tablecheck/tablekit-tag@1.0.1, @tablecheck/tablekit-textarea@1.0.1, @tablecheck/tablekit-toggle@1.0.1, @tablecheck/tablekit-tooltip@1.0.1, @tablecheck/tablekit-topnav@1.0.1 🚀

@tablecheck-public-automation tablecheck-public-automation added the released This issue/pull request has been released. label Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimeonC SimeonC SimeonC approved these changes

@gazpachu gazpachu gazpachu approved these changes

Assignees
No one assigned
Labels
documentation Changes only affect the documentation released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate unapproved stories to GitHub
4 participants
@irmir @SimeonC @tablecheck-public-automation @gazpachu