fix(tablekit-banner): fix icon alignment #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irmir
force-pushed
the
fix-banner-icon-alignment
branch
from
4298db9
to
44e1353
Compare
wahidfarid
requested changes
Aug 25, 2021
|
I have some other comments, but we need #36 merged before we can review this one. And as Wahid pointed out, can you include "Before fix" and "After fix" screenshots. I tried rebasing this onto the other branch so I could see the example stories but I still don't know "what" you're trying to fix. |
|
@wahidmagdy @SimeonC I added screenshots. Sorry for the inconvenience, in GitLab we had discussion with Joan about it and also had screenshots of the problem |
SimeonC
requested changes
Aug 26, 2021
irmir
force-pushed
the
fix-banner-icon-alignment
branch
3 times, most recently
from
ddbe7c6
to
2ba4e9b
Compare
SimeonC
previously approved these changes
Feb 18, 2022
irmir
force-pushed
the
fix-banner-icon-alignment
branch
from
2ba4e9b
to
4d5461a
Compare
irmir
force-pushed
the
fix-banner-icon-alignment
branch
from
4d5461a
to
d4b398c
Compare
SimeonC
approved these changes
Feb 18, 2022
staevs
approved these changes
Feb 18, 2022
wahidfarid
approved these changes
Feb 21, 2022
|
🚀 PR was released in |
tablecheck-public-automation
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did vertical alignment on the middle for all examples except banner with long message
before:
after:
closes #39
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @tablecheck/tablekit-banner@2.1.2-canary.40.1863701405.0 # or yarn add @tablecheck/tablekit-banner@2.1.2-canary.40.1863701405.0