Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jetbrains: reduce log output, better error output #1411

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

timo
Copy link
Contributor

@timo timo commented Apr 1, 2024

until now, finding the vcidea_foo file still resulted in an error that the .vcidea_foo file was not found, which is confusing. also, there's always many lines per command executed, with this patch it's just one when it works.
If there's an error with the vcidea nonce file, or if the port isn't found, there will now be a hint that vscode-idea commands will not work, and when the vcidea file is not found, the actual locations we looked will be put into the log message as well, so you don't have to guess or investigate with the REPL or something

@timo
Copy link
Contributor Author

timo commented Apr 1, 2024

2024-04-01 20:28:03.909    IO executing jetbrains action EditorCopy
2024-04-01 20:28:03.910    IO Sending action EditorCopy
2024-04-01 20:28:03.911    IO Could not find .vcidea_8654 in tmp or home
2024-04-01 20:28:03.912    IO sending IntelliJ IDEA 8654 blablablabla-blablabla=

this is what executing a single command looks like in the log before this patch

timo and others added 2 commits April 12, 2024 20:39
until now, finding the vcidea_foo file still resulted in an error that
the .vcidea_foo file was not found, which is confusing. also, there's
always many lines per command executed, with this patch it's just
one when it works.
If there's an error with the vcidea nonce file, or if the port isn't found,
there will now be a hint that vscode-idea commands will not work,
and when the vcidea file is not found, the actual locations we looked
will be put into the log message as well, so you don't have to guess
or investigate with the REPL or something
@timo timo force-pushed the jetbrains_better_log_output branch from 1b5ad44 to 825857e Compare April 12, 2024 18:39
@timo
Copy link
Contributor Author

timo commented Apr 15, 2024

here's real log output from a real user where four commands are sent to the idea plugin

2024-04-15 19:05:30.743    IO sending voicecode-idea command action IntroduceField to IntelliJ IDEA 8654 blablablabla-blablabla=
2024-04-15 19:05:42.091    IO sending voicecode-idea command action FindUsages to IntelliJ IDEA 8654 blablablabla-blablabla=
2024-04-15 19:05:52.773    IO sending voicecode-idea command action SearchEverywhere to IntelliJ IDEA 8654 blablablabla-blablabla=
2024-04-15 19:06:09.357    IO sending voicecode-idea command action SmartTypeCompletion to IntelliJ IDEA 8654 blablablabla-blablabla=

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant