jetbrains: Clean up and fix logging and error handling #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auscompgeek
changed the title
phillco
reviewed
May 25, 2024
| for cmd in command_list: | ||
| if cmd: | ||
| send_idea_command(cmd.strip()) | ||
| actions.sleep(0.1) |
There was a problem hiding this comment.
Doesn't have to be done in this PR but we should really see if this can be removed. It makes the running of multiple actions like idea_grab() unnecessarily slower/jankier.
(I ran with it removed for many months, but I've since diverged from community enough that it'd be good for someone else to test too)
phillco
approved these changes
May 26, 2024
| actions.sleep(0.1) | ||
| except Exception as e: | ||
| app.notify(e) | ||
| raise e |
There was a problem hiding this comment.
I was going to recommend just raise, but it looks like in Python 3 this doesn't actually remove any of the context, waited under Python 2? https://stackoverflow.com/a/45986945/303833
|
#1411 is there and does something similar. which of the two do you prefer @auscompgeek ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extendCommandsvariable