Avoid hardcoded xdg-open path and resolve incoming paths #1531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auscompgeek
reviewed
Aug 7, 2024
| @@ -67,7 +71,11 @@ def edit_text_file(path): | |||
| # we use xdg-open for this even though it might not open a text | |||
| # editor. we could use $EDITOR, but that might be something that | |||
| # requires a terminal (eg nano, vi). | |||
| open_with_subprocess(path, ["/usr/bin/xdg-open", path]) | |||
| open_cmd = shutil.which("xdg-open") | |||
There was a problem hiding this comment.
I had raised that this would be a problem on NixOS back in the original PR too: #847 (comment)
Time to start this discussion again I guess. cc @rntz
There was a problem hiding this comment.
If we are concerned about malicious binaries injected into PATH folders enough to avoid calling which, then I can change it to test a set of hardcoded paths to try find it and include /run/current-system/sw/bin/ for nixos, though I'm not sure that will always work for all possible setups. Could cache the path after the first go to not have to search through a list each time too.
There is a which call in PR #1471, to fix a similar issue on nixos, that will need to change depending on what gets decided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes using xdg-open while on nixos and also resolves paths passed in, so if someone uses ~/ or similar in their path it'll work.