add user.open_file action and list/commands for editing settings csvs

[rntz]

Changes:

1. Adds a new user.open_file action which opens a file in whatever the appropriate application is.

2. Adds a list user.talon_settings_csv for paths to talon user settings csv files, e.g. additional_words.csv, search_engines.csv, etc.

3. Adds a command customize {user.talon_settings_csv) that opens the corresponding csv and jumps to end of file.

This is heavily based on #810.

Feedback requested:

1. Is customize the command prefix we want here? At present this will bind the ccommands:

   customize search engines
   customize websites
   customize file extensions
   customize system paths
   customize words to replace
   customize additional words
   

   Alternatives might be edit or open (a bit short), add new, edit talon, edit {talon_settings_csv} csv.

2. Is there a better place to put this command than in a new file? Maybe standard.talon?

[pokey]

This is really nice! I like how you've factored the original PR into one clean concern. I actually think you could factor it even more, though. I don't feel super strongly, but see comments

[pokey]

I think maybe this stuff would go into a separate file, along with the proposed edit_user_file

[rntz]

Yeah, it might belong in user_settings.py

[codecat555]

This looks good, I agree it's an improvement on what I submitted in #810.

[rntz]

Ok, we rewrote this during the maintenance session to make the following changes:

1. We now use contexts instead of examining app.platform.
2. The action is named edit_text_file, since that's our current use-case for it. We can add an open_file command later if we need it.
3. The action doesn't do any path handling and doesn't wait for 500ms. (Instead the "customize" voice commmand calls sleep.) This should make it easier for users to override the action if they want it to do something else.
4. The action does error handling on each platform.
5. The action tries to open the file in a text editor if there's a natural way to do that (eg. invoking the 'edit' action on Windows, passing the -t flag on Mac).

Would appreciate another review.

[pokey]

Beautiful 👏

Lmk if you want me to test it out locally; otherwise feel free to merge it in

[nriley]

WFM on macOS and Windows. Perhaps consider renaming open_file.py to edit_[text_]file.py?

[codecat555]

Must be, because in this case no Talon api is even involved.

…

On Sat, Jun 4, 2022, 3:07 PM Pokey Rule ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In code/open_file.py <#847 (comment)>: > @@ -0,0 +1,80 @@ +# Actions for opening files in appropriate applications. +import os +import subprocess + +from talon import Context, Module, app + +# path to knausj root directory +REPO_DIR = os.path.dirname(os.path.dirname(__file__)) +SETTINGS_DIR = os.path.join(REPO_DIR, "settings") Talon's watch function doesn't work with symlinks. Maybe that's what you're thinking of? — Reply to this email directly, view it on GitHub <#847 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEGOOR24MCTVTLVPC2P3HDTVNPHTRANCNFSM5VOS3NMQ> . You are receiving this because you commented.Message ID: ***@***.***>