feat(claim_burn)!: adds encrypted value to UnclaimedConfidentialOutput substate #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
claim-burn-dh-mask-ev
branch
from
821db49
to
923bdab
Compare
3 tasks
stringhandler
previously approved these changes
Mar 13, 2023
| @@ -79,10 +84,11 @@ pub struct GetByNameArgs { | |||
|
|
|||
| #[derive(Debug, Args, Clone)] | |||
| pub struct ClaimBurnArgs { | |||
| #[clap(long, short = 'a')] | |||
| account_address: ComponentAddress, | |||
| #[clap(long, short = 'n', alias = "name")] | |||
There was a problem hiding this comment.
thanks, this is better
sdbondi
force-pushed
the
claim-burn-dh-mask-ev
branch
from
20e1e64
to
285925f
Compare
stringhandler
approved these changes
Mar 13, 2023
sdbondi
added a commit
to sdbondi/tari-dan
that referenced
this pull request
Mar 13, 2023
* development: feat(claim_burn)!: adds encrypted value to UnclaimedConfidentialOutput substate (tari-project#427)
sdbondi
added a commit
to sdbondi/tari-dan
that referenced
this pull request
Mar 13, 2023
* development: feat(wallet)!: monitor accounts for received funds (tari-project#425) feat(claim_burn)!: adds encrypted value to UnclaimedConfidentialOutput substate (tari-project#427)
sdbondi
added a commit
that referenced
this pull request
Mar 14, 2023
…429) Description --- feat: add endpoint for generating output proofs for minting feat: support base64 blob in cli args and manifest globals Motivation and Context --- When minting a confidential resource, an output commitment proof is required. This PR adds cli tools to support this. The key used for the proof is from the key manager but we wont know which key to use for the transfer proof. This is out of scope and requires PRs (#427 #425) to be merged before this can be worked on. We may need the walletd to associate a key for all owned vaults regardless if they are part of an Account component so that transfer proofs can be generated. How Has This Been Tested? --- Manually, `ConfidentialFaucet::mint` template call. What process can a PR reviewer use to test or verify this change? --- ```shell $ cargo run --bin tari_dan_wallet_cli -- proofs generate 10000 -o base64 > ./proof.txt $ cargo run --bin tari_dan_wallet_cli -- transactions submit-manifest -n3 ./manifest.rs -g proof=file://./proof.txt ``` Breaking Changes --- - [x] None - [ ] Requires data directory to be deleted - [ ] Other - Please specify
sdbondi
added a commit
to stringhandler/tari-dan
that referenced
this pull request
Mar 15, 2023
* development: feat(cli): generate output proof for minting, support file blob args (tari-project#429) feat(wallet)!: monitor accounts for received funds (tari-project#425) feat(claim_burn)!: adds encrypted value to UnclaimedConfidentialOutput substate (tari-project#427) feat: transaction filter (tari-project#428) feat: update to tari newest tari version (tari-project#424) feat: add missing wallet daemon cli request for claim burn (tari-project#426) feat: add handle claim burn to wallet daemon accounts (tari-project#422) feat: ui improvements (tari-project#419) fix: fix claim commsig, allow JSON to be pasted on cli (tari-project#421) feat(indexer): track all NFT's of a resource (tari-project#420) feat: add transfer of confidential assets to wallet cli (tari-project#412) feat(wallet): add apis and implementation for confidential withdraws (tari-project#417) v0.50.0-pre.0 feat: adds public nonce and encrypted value data to confidential resources (tari-project#413)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Depends on tari-project/tari#5238
Ref #425 - this PR will need to be updated to use the correct hasher (can be merged in any order though)
How Has This Been Tested?
Claim burn cucumber
What process can a PR reviewer use to test or verify this change?
Use POSTMan to burn funds (using wallet with tari-project/tari#5238)
Run vn and wallet daemon
Breaking Changes