fix: fix claim commsig, allow JSON to be pasted on cli #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
fix-claim-burn
branch
2 times, most recently
from
420bb66
to
a1f0907
Compare
|
Decided to lock tari to 0.47.0-pre-0 , otherwise I'd need to implement the BalancedMerkleTree in this PR |
stringhandler
pushed a commit
to tari-project/tari
that referenced
this pull request
Mar 8, 2023
Description --- Fixes compile error caused by breaking change for decimal-rs >=0.1.42 Motivation and Context --- decimal-rs removed the Error impl for their error type in 0.1.42 but released this breaking change as a patch. The thiserror from impl requires that the Error trait be implemented so this PR manually implements From ~~Causing compile error in tari-project/tari-dan#421 worked around this and other issues by not updating all dependencies and locking to 0.47.0-pre.0 tag. How Has This Been Tested? --- Code compiles <!-- Does this include a breaking change? If so, include this line as a footer --> <!-- BREAKING CHANGE: Description what the user should do, e.g. delete a database, resync the chain -->
sdbondi
added a commit
to stringhandler/tari-dan
that referenced
this pull request
Mar 15, 2023
* development: feat(cli): generate output proof for minting, support file blob args (tari-project#429) feat(wallet)!: monitor accounts for received funds (tari-project#425) feat(claim_burn)!: adds encrypted value to UnclaimedConfidentialOutput substate (tari-project#427) feat: transaction filter (tari-project#428) feat: update to tari newest tari version (tari-project#424) feat: add missing wallet daemon cli request for claim burn (tari-project#426) feat: add handle claim burn to wallet daemon accounts (tari-project#422) feat: ui improvements (tari-project#419) fix: fix claim commsig, allow JSON to be pasted on cli (tari-project#421) feat(indexer): track all NFT's of a resource (tari-project#420) feat: add transfer of confidential assets to wallet cli (tari-project#412) feat(wallet): add apis and implementation for confidential withdraws (tari-project#417) v0.50.0-pre.0 feat: adds public nonce and encrypted value data to confidential resources (tari-project#413)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Claim burn works
How Has This Been Tested?
Manually
What process can a PR reviewer use to test or verify this change?
Burn funds on L1 using POSTman
Copy JSON from result
run:
cargo run --bin tari_dan_wallet_cli -- accounts get-balances --account-name primaryPaste JSON
Breaking Changes