Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix compile error caused by decimal-rs 0.1.42 #5228

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Mar 8, 2023

Description

Fixes compile error caused by breaking change for decimal-rs >=0.1.42

Motivation and Context

decimal-rs removed the Error impl for their error type in 0.1.42 but released this breaking change as a patch.
The thiserror from impl requires that the Error trait be implemented so this PR manually implements From

Causing compile error in tari-project/tari-dan#421 worked around this and other issues by not updating all dependencies and locking to 0.47.0-pre.0 tag.

How Has This Been Tested?

Code compiles

@sdbondi sdbondi changed the title fix: fix compile error using decimal-rs 0.1.42 fix: fix compile error caused by decimal-rs 0.1.42 Mar 8, 2023
@stringhandler stringhandler merged commit 6edbb1c into tari-project:development Mar 8, 2023
@sdbondi sdbondi deleted the update-decimal-rs branch March 8, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants