Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FR: Allow pipeline resources to be declared as optional #1710

Closed
pritidesai opened this issue Dec 9, 2019 · 2 comments · Fixed by #1910
Closed

FR: Allow pipeline resources to be declared as optional #1710

pritidesai opened this issue Dec 9, 2019 · 2 comments · Fixed by #1910
Assignees
@pritidesai
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@pritidesai
Copy link
Member

Expected Behavior

We have an issue (#812) and PR (#1601) to allow Task authors to declare resources as optional. We need the same support for Pipeline authors.

Actual Behavior

Resources can not be declared as optional in a Pipeline.
@pritidesai pritidesai mentioned this issue Dec 9, 2019
Merged
3 tasks
@pritidesai
Copy link
Member Author

/assign pritidesai

@vdemeester
Copy link
Member

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 10, 2019
@ghost ghost mentioned this issue Dec 10, 2019
Closed
pritidesai added a commit to pritidesai/pipeline that referenced this issue Dec 19, 2019
@pritidesai
Allow Resources to be Optional in Pipeline
620fdb5 
Pipeline inputs and outputs are considered required, there is no way
today to mark them optional. This change introduced a new field called
optional as part of the PipelineTaskInputResource and PipelineTaskOutputResource
by default a resource is required. To mark any resource optional, set optional to true:

apiVersion: tekton.dev/v1alpha1
kind: Pipeline
metadata:
 name: pipeline-build-image
spec:
 inputs:
   resources:
     - name: workspace
       type: git
       optional: true
 tasks:
   - name: check-workspace

Closes tektoncd#1710
pritidesai added a commit to pritidesai/pipeline that referenced this issue Dec 19, 2019
@pritidesai
Allow Resources to be Optional in Pipeline
955106a 
Pipeline inputs and outputs are considered required, there is no way
today to mark them optional. This change introduced a new field called
optional as part of the PipelineTaskInputResource and PipelineTaskOutputResource
by default a resource is required. To mark any resource optional, set optional to true:

apiVersion: tekton.dev/v1alpha1
kind: Pipeline
metadata:
 name: pipeline-build-image
spec:
 inputs:
   resources:
     - name: workspace
       type: git
       optional: true
 tasks:
   - name: check-workspace

Closes tektoncd#1710
pritidesai added a commit to pritidesai/pipeline that referenced this issue Dec 19, 2019
@pritidesai
Allow Resources to be Optional in Pipeline
ba3f0b9 
Pipeline inputs and outputs are considered required, there is no way
today to mark them optional. This change introduced a new field called
optional as part of the PipelineTaskInputResource and PipelineTaskOutputResource
by default a resource is required. To mark any resource optional, set optional to true:

apiVersion: tekton.dev/v1alpha1
kind: Pipeline
metadata:
 name: pipeline-build-image
spec:
 inputs:
   resources:
     - name: workspace
       type: git
       optional: true
 tasks:
   - name: check-workspace

Closes tektoncd#1710
pritidesai added a commit to pritidesai/pipeline that referenced this issue Dec 19, 2019
@pritidesai
Allow Resources to be Optional in Pipeline
7784389 
Pipeline inputs and outputs are considered required, there is no way
today to mark them optional. This change introduced a new field called
optional as part of the PipelineTaskInputResource and PipelineTaskOutputResource
by default a resource is required. To mark any resource optional, set optional to true:

apiVersion: tekton.dev/v1alpha1
kind: Pipeline
metadata:
 name: pipeline-build-image
spec:
 inputs:
   resources:
     - name: workspace
       type: git
       optional: true
 tasks:
   - name: check-workspace

Closes tektoncd#1710
pritidesai added a commit to pritidesai/pipeline that referenced this issue Dec 19, 2019
@pritidesai
Allow Resources to be Optional in Pipeline
d7ec631 
Pipeline inputs and outputs are considered required, there is no way
today to mark them optional. This change introduced a new field called
optional as part of the PipelineTaskInputResource and PipelineTaskOutputResource
by default a resource is required. To mark any resource optional, set optional to true:

apiVersion: tekton.dev/v1alpha1
kind: Pipeline
metadata:
 name: pipeline-build-image
spec:
 inputs:
   resources:
     - name: workspace
       type: git
       optional: true
 tasks:
   - name: check-workspace

Closes tektoncd#1710
pritidesai added a commit to pritidesai/pipeline that referenced this issue Jan 6, 2020
@pritidesai
Allow Resources to be Optional in Pipeline
d61d2f2 
Pipeline inputs and outputs are considered required, there is no way
today to mark them optional. This change introduces a new field called
optional as part of the PipelineTaskInputResource and PipelineTaskOutputResource
by default a resource is required. To mark any resource optional, set optional to true:

apiVersion: tekton.dev/v1alpha1
kind: Pipeline
metadata:
 name: pipeline-build-image
spec:
 inputs:
   resources:
     - name: workspace
       type: git
       optional: true
 tasks:
   - name: check-workspace

Closes tektoncd#1710
pritidesai added a commit to pritidesai/pipeline that referenced this issue Jan 15, 2020
@pritidesai
Allow Resources to be Optional in Pipeline
f22bfb1 
Pipeline inputs and outputs are considered required, there is no way
today to mark them optional. This change introduces a new field called
optional as part of the PipelineTaskInputResource and PipelineTaskOutputResource
by default a resource is required. To mark any resource optional, set optional to true:

apiVersion: tekton.dev/v1alpha1
kind: Pipeline
metadata:
 name: pipeline-build-image
spec:
 inputs:
   resources:
     - name: workspace
       type: git
       optional: true
 tasks:
   - name: check-workspace

Closes tektoncd#1710
pritidesai added a commit to pritidesai/pipeline that referenced this issue Jan 21, 2020
@pritidesai
Enabling Pipeline Resources to be marked as Optional
9c01df3 
Pipeline inputs and outputs are considered required, there is no way
today to mark them optional. This change introduces a new field called
optional as part of the PipelineDeclaredResource similar to previous PR tektoncd#1601,
by default optional is set to false and a resource is required.
To mark any resource optional, set optional to true:

apiVersion: tekton.dev/v1alpha1
kind: Pipeline
metadata:
 name: pipeline-build-image
spec:
 resources:
   - name: workspace
     type: git
     optional: true
 tasks:
   - name: check-workspace

Closes tektoncd#1710
pritidesai added a commit to pritidesai/pipeline that referenced this issue Jan 21, 2020
@pritidesai
Enabling Pipeline Resources to be marked as Optional
09a5c98 
Pipeline inputs and outputs are considered required, there is no way
today to mark them optional. This change introduces a new field called
optional as part of the PipelineDeclaredResource similar to previous PR tektoncd#1601,
by default optional is set to false and a resource is required.
To mark any resource optional, set optional to true:

apiVersion: tekton.dev/v1alpha1
kind: Pipeline
metadata:
 name: pipeline-build-image
spec:
 resources:
   - name: workspace
     type: git
     optional: true
 tasks:
   - name: check-workspace

Closes tektoncd#1710
@pritidesai pritidesai mentioned this issue Jan 21, 2020
Merged
3 tasks
pritidesai added a commit to pritidesai/pipeline that referenced this issue Jan 21, 2020
@pritidesai
Enabling Pipeline Resources to be marked as Optional
5fb1297 
Pipeline inputs and outputs are considered required, there is no way
today to mark them optional. This change introduces a new field called
optional as part of the PipelineDeclaredResource similar to previous PR tektoncd#1601,
by default optional is set to false and a resource is required.
To mark any resource optional, set optional to true:

apiVersion: tekton.dev/v1alpha1
kind: Pipeline
metadata:
 name: pipeline-build-image
spec:
 resources:
   - name: workspace
     type: git
     optional: true
 tasks:
   - name: check-workspace

Closes tektoncd#1710
pritidesai added a commit to pritidesai/pipeline that referenced this issue Jan 21, 2020
@pritidesai
Enabling Pipeline Resources to be marked as Optional
5bfa6b7 
Pipeline inputs and outputs are considered required, there is no way
today to mark them optional. This change introduces a new field called
optional as part of the PipelineDeclaredResource similar to previous PR tektoncd#1601,
by default optional is set to false and a resource is required.
To mark any resource optional, set optional to true:

apiVersion: tekton.dev/v1alpha1
kind: Pipeline
metadata:
 name: pipeline-build-image
spec:
 resources:
   - name: workspace
     type: git
     optional: true
 tasks:
   - name: check-workspace

Closes tektoncd#1710
pritidesai added a commit to pritidesai/pipeline that referenced this issue Jan 22, 2020
@pritidesai
Enabling Pipeline Resources to be marked as Optional
bfecdca 
Pipeline inputs and outputs are considered required, there is no way
today to mark them optional. This change introduces a new field called
optional as part of the PipelineDeclaredResource similar to previous PR tektoncd#1601,
by default optional is set to false and a resource is required.
To mark any resource optional, set optional to true:

apiVersion: tekton.dev/v1alpha1
kind: Pipeline
metadata:
 name: pipeline-build-image
spec:
 resources:
   - name: workspace
     type: git
     optional: true
 tasks:
   - name: check-workspace

Closes tektoncd#1710
pritidesai added a commit to pritidesai/pipeline that referenced this issue Jan 23, 2020
@pritidesai
Enabling Pipeline Resources to be marked as Optional
d447219 
Pipeline inputs and outputs are considered required, there is no way
today to mark them optional. This change introduces a new field called
optional as part of the PipelineDeclaredResource similar to previous PR tektoncd#1601,
by default optional is set to false and a resource is required.
To mark any resource optional, set optional to true:

apiVersion: tekton.dev/v1alpha1
kind: Pipeline
metadata:
 name: pipeline-build-image
spec:
 resources:
   - name: workspace
     type: git
     optional: true
 tasks:
   - name: check-workspace

Closes tektoncd#1710
pritidesai added a commit to pritidesai/pipeline that referenced this issue Jan 23, 2020
@pritidesai
Enabling Pipeline Resources to be marked as Optional
d63abc6 
Pipeline inputs and outputs are considered required, there is no way
today to mark them optional. This change introduces a new field called
optional as part of the PipelineDeclaredResource similar to previous PR tektoncd#1601,
by default optional is set to false and a resource is required.
To mark any resource optional, set optional to true:

apiVersion: tekton.dev/v1alpha1
kind: Pipeline
metadata:
 name: pipeline-build-image
spec:
 resources:
   - name: workspace
     type: git
     optional: true
 tasks:
   - name: check-workspace

Closes tektoncd#1710
tekton-robot pushed a commit that referenced this issue Feb 3, 2020
@pritidesai @tekton-robot
Enabling Pipeline Resources to be marked as Optional
aee09da 
Pipeline inputs and outputs are considered required, there is no way
today to mark them optional. This change introduces a new field called
optional as part of the PipelineDeclaredResource similar to previous PR #1601,
by default optional is set to false and a resource is required.
To mark any resource optional, set optional to true:

apiVersion: tekton.dev/v1alpha1
kind: Pipeline
metadata:
 name: pipeline-build-image
spec:
 resources:
   - name: workspace
     type: git
     optional: true
 tasks:
   - name: check-workspace

Closes #1710
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pritidesai pritidesai

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enabling Pipeline Resources to be marked as Optional pritidesai/pipeline
3 participants
@vdemeester @pritidesai @tekton-robot