Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FR: Allow Resources to be declared as "optional" #812

Closed
dlorenc opened this issue Apr 30, 2019 · 5 comments · Fixed by #1601
Closed

FR: Allow Resources to be declared as "optional" #812

dlorenc opened this issue Apr 30, 2019 · 5 comments · Fixed by #1601
Assignees
@pritidesai
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@dlorenc
Copy link
Contributor

dlorenc commented Apr 30, 2019

Expected Behavior

Task authors should be able to declare some Inputs as "optional".

Actual Behavior

Today all declared input resources must be supplied.
@dlorenc
Copy link
Contributor Author

dlorenc commented Apr 30, 2019

Example use-cases:

  • A "deployment" task that can deploy to a specified cluster, but defaults to the cluster it is running in.
  • A task that can optionally upload artifacts to an artifact store, but does not need to.

@bobcatfish bobcatfish added this to the Pipelines 0.8 🐱 milestone Sep 10, 2019
@pritidesai
Copy link
Member

/assign pritidesai

pritidesai added a commit to pritidesai/catalog that referenced this issue Sep 25, 2019
@pritidesai
OpenWhisk Deployment with Conditions
5aaad55 
Adding tekton resources such as conditions, pipeline, and
pipelinerun with updated openwhisk.yaml so that the
deployment can pull entire github repo with the application source,
install necessary dependencies, archive the source with its dependencies,
and inject base64 encoded data into OpenWhisk runtime.

Note that, have added openwhisk.yaml under runtimes/javascript/ since
Tekton Pipeline does not yet support optional pipeline resources such as,
this is tracked as part of tektoncd/pipeline#812
once this is fixed, will update original openwhisk.yaml
@pritidesai pritidesai mentioned this issue Sep 25, 2019
Closed
2 tasks
@bobcatfish bobcatfish removed this from the Pipelines 0.8 🐱 milestone Oct 3, 2019
@vdemeester
Copy link
Member

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 7, 2019
@ghost ghost mentioned this issue Nov 12, 2019
Merged
@ghost
Copy link

ghost commented Nov 12, 2019

gke-deploy Task in the catalog could use this functionality: tektoncd/catalog#126

That task would ideally be able to accept either a cluster resource OR the necessary args to configure access to that cluster. Very similar to the first example use case mentioned by @dlorenc

@pritidesai
Copy link
Member

Design Doc: https://docs.google.com/document/d/1oe936Zspc8jL9Tb7kWd26bS6sf2emxUxTjt-aKv01Mc/edit#heading=h.duu98lpb6lg4

@pritidesai pritidesai mentioned this issue Nov 22, 2019
Merged
3 tasks
@pritidesai pritidesai mentioned this issue Dec 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pritidesai pritidesai

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow Resources to be Optional in Task, ClusterTask, and Condition pritidesai/pipeline
5 participants
@vdemeester @pritidesai @bobcatfish @dlorenc @tekton-robot