Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Start using knative PermanentErrors in reconcilers #2474

Closed
afrittoli opened this issue Apr 23, 2020 · 1 comment · Fixed by #2802
Closed

[feature] Start using knative PermanentErrors in reconcilers #2474

afrittoli opened this issue Apr 23, 2020 · 1 comment · Fixed by #2802
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@afrittoli
Copy link
Member

afrittoli commented Apr 23, 2020 •
edited
Loading

Expected Behavior

Distinguish explicitly between permanent errors and transient ones in the reconciler code.

Actual Behavior

Today we capture errors that are considered permanent in Reconcile so that we can return nil and the key is not directly requeued. So we use the same semantic to indicate no error and permanent error.

Knative pkg defines PermanentError: when Reconcile is invoked on an object taken from the queue, if it returns PermanentError the object is not requeued.
This allows being explicit in the reconcile code about which error is considered a permanent one.

/kind feature
@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 23, 2020
@vdemeester
Copy link
Member

/kind cleanup

@tekton-robot tekton-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Apr 23, 2020
@afrittoli afrittoli mentioned this issue May 19, 2020
Closed
3 tasks
afrittoli added a commit to afrittoli/pipeline that referenced this issue Jun 10, 2020
@afrittoli
Use permanent errors in the pipelinerun reconciler
ed20e5f 
Instead of returning nil on error during reconcile, if the error
is transient return it, so that the key is requeue. If the error
is permanent return a permanent error, so that the key is not
requeued.

Partially addresses tektoncd#2474
afrittoli added a commit to afrittoli/pipeline that referenced this issue Jun 10, 2020
@afrittoli
Use permanent errors in the pipelinerun reconciler
82d0b05 
Instead of returning nil on error during reconcile, if the error
is transient return it, so that the key is requeue. If the error
is permanent return a permanent error, so that the key is not
requeued.

Partially addresses tektoncd#2474
This was referenced Jun 10, 2020
Merged
Merged
afrittoli added a commit to afrittoli/pipeline that referenced this issue Jun 10, 2020
@afrittoli
Use permanent errors in the pipelinerun reconciler
bad6378 
Instead of returning nil on error during reconcile, if the error
is transient return it, so that the key is requeue. If the error
is permanent return a permanent error, so that the key is not
requeued.

Partially addresses tektoncd#2474
afrittoli added a commit to afrittoli/pipeline that referenced this issue Jun 11, 2020
@afrittoli
Use permanent errors in the pipelinerun reconciler
ae00370 
Instead of returning nil on error during reconcile, if the error
is transient return it, so that the key is requeue. If the error
is permanent return a permanent error, so that the key is not
requeued.

Partially addresses tektoncd#2474
afrittoli added a commit to afrittoli/pipeline that referenced this issue Jun 23, 2020
@afrittoli
Use permanent errors in the pipelinerun reconciler
190ad5f 
Instead of returning nil on error during reconcile, if the error
is transient return it, so that the key is requeue. If the error
is permanent return a permanent error, so that the key is not
requeued.

Partially addresses tektoncd#2474
afrittoli added a commit to afrittoli/pipeline that referenced this issue Jun 23, 2020
@afrittoli
Use permanent errors in the pipelinerun reconciler
2d8ed37 
Instead of returning nil on error during reconcile, if the error
is transient return it, so that the key is requeue. If the error
is permanent return a permanent error, so that the key is not
requeued.

Partially addresses tektoncd#2474
afrittoli added a commit to afrittoli/pipeline that referenced this issue Jun 24, 2020
@afrittoli
Use permanent errors in the pipelinerun reconciler
043bea9 
Instead of returning nil on error during reconcile, if the error
is transient return it, so that the key is requeue. If the error
is permanent return a permanent error, so that the key is not
requeued.

Partially addresses tektoncd#2474
afrittoli added a commit to afrittoli/pipeline that referenced this issue Jun 24, 2020
@afrittoli
Use permanent errors in the pipelinerun reconciler
6760e96 
Instead of returning nil on error during reconcile, if the error
is transient return it, so that the key is requeue. If the error
is permanent return a permanent error, so that the key is not
requeued.

Partially addresses tektoncd#2474
tekton-robot pushed a commit that referenced this issue Jun 25, 2020
@afrittoli @tekton-robot
Use permanent errors in the pipelinerun reconciler
44f22a0 
Instead of returning nil on error during reconcile, if the error
is transient return it, so that the key is requeue. If the error
is permanent return a permanent error, so that the key is not
requeued.

Partially addresses #2474
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use permanent errors in the taskrun reconciler afrittoli/pipeline
3 participants
@vdemeester @afrittoli @tekton-robot