Use permanent errors in the taskrun reconciler #2802
Conversation
tekton-robot
added
the
kind/cleanup
tekton-robot
added
the
size/L
|
This PR cannot be merged: expecting exactly one kind/ label Available
|
|
The following is the coverage report on the affected files.
|
|
/cc @vdemeester @mattmoor |
afrittoli
force-pushed
the
isssues/2474-pe-taskrun
branch
from
81a64c2
to
70c639b
Compare
Instead of returning nil on error during reconcile, if the error is transient return it, so that the key is requeue. If the error is permanent return a permanent error, so that the key is not requeued.
afrittoli
force-pushed
the
isssues/2474-pe-taskrun
branch
from
70c639b
to
7a4de99
Compare
|
The following is the coverage report on the affected files.
|
|
/test tekton-pipeline-unit-tests |
| t.Logf("Creating SA %s in %s", "default", "foo") | ||
| if _, err := clients.Kube.CoreV1().ServiceAccounts("foo").Create(&corev1.ServiceAccount{ | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Name: "default", | ||
| Namespace: "foo", | ||
| }, | ||
| }); err != nil { | ||
| t.Fatal(err) | ||
| } |
There was a problem hiding this comment.
If you remove it the test will fail with missing service account.
It looks like returning the error exposes some hidden issues in existing tests.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bobcatfish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
| @@ -437,19 +438,21 @@ func (c *Reconciler) handlePodCreationError(ctx context.Context, tr *v1beta1.Tas | |||
| Reason: podconvert.ReasonExceededResourceQuota, | |||
| Message: fmt.Sprintf("%s: %v", msg, err), | |||
| }) | |||
| // return a transient error, so that the key is requeued | |||
| return err | |||
There was a problem hiding this comment.
Hi, @afrittoli AFAIK, the key will be requeued by the SetTaskRunTimer function, I am curious about whether the key will be requeued twice if we returned a transient error here?
Changes
Instead of returning nil on error during reconcile, if the error
is transient return it, so that the key is requeue. If the error
is permanent return a permanent error, so that the key is not
requeued.
Fixes #2474
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
/kind cleanup