Adding support to enable pipelineSpec #1333

pritidesai · 2019-09-19T17:43:00Z

Changes

Its now possible to embed the whole pipeline specification into Pipeline Run
using pipelineSpec, for example:

apiVersion: tekton.dev/v1alpha1
kind: PipelineRun
metadata:
  name: pipelinerun-echo-greetings
spec:
  pipelineRef:
    name: pipeline-echo-greetings

Can be specified as:

apiVersion: tekton.dev/v1alpha1
kind: PipelineRun
metadata:
  name: pipelinerun-echo-greetings
spec:
  pipelineSpec:
    tasks:
    - name: echo-good-morning
    ...
    params:
    ...

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Includes tests (if functionality changed/added)
Includes docs (if user facing)
Commit messages follow commit message best practices

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

If you are adding a new binary/image to the cmd dir, please update
the release Task and TaskRun to build and release this image

Reviewer Notes

If API changes
are included, additive changes
must be approved by at least two OWNERS
and backwards incompatible changes
must be approved by more than 50% of the OWNERS,
and they must first be added
in a backwards compatible way.

Release Notes

Describe any user facing changes here, or delete this block.

Examples of user facing changes:
- API changes
- Bug fixes
- Any changes in behavior

tekton-robot · 2019-09-19T17:43:14Z

Hi @pritidesai. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

docs/pipelineruns.md

pkg/apis/pipeline/v1alpha1/pipelinerun_types.go

tekton-robot · 2019-09-20T05:39:31Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/pipeline_types.go	Do not exist	0.0%
pkg/apis/pipeline/v1alpha1/pipelinerun_validation.go	92.9%	89.5%	-3.4
pkg/reconciler/pipelinerun/pipelinerun.go	82.4%	83.0%	0.6
pkg/reconciler/pipelinerun/resources/pipelinespec.go	Do not exist	100.0%

pritidesai · 2019-09-20T05:57:40Z

/ok-to-test

pritidesai · 2019-09-20T05:58:14Z

/assign pritidesai

tekton-robot · 2019-09-20T05:59:41Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/pipeline_types.go	Do not exist	0.0%
pkg/apis/pipeline/v1alpha1/pipelinerun_validation.go	92.9%	89.5%	-3.4
pkg/reconciler/pipelinerun/pipelinerun.go	82.4%	83.0%	0.6
pkg/reconciler/pipelinerun/resources/pipelinespec.go	Do not exist	100.0%

tekton-robot · 2019-09-20T06:13:10Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/pipeline_types.go	Do not exist	0.0%
pkg/apis/pipeline/v1alpha1/pipelinerun_validation.go	92.9%	89.5%	-3.4
pkg/reconciler/pipelinerun/pipelinerun.go	82.4%	83.0%	0.6
pkg/reconciler/pipelinerun/resources/pipelinespec.go	Do not exist	100.0%

tekton-robot · 2019-09-20T06:19:30Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/pipeline_types.go	Do not exist	0.0%
pkg/apis/pipeline/v1alpha1/pipelinerun_validation.go	92.9%	89.5%	-3.4
pkg/reconciler/pipelinerun/pipelinerun.go	82.4%	83.0%	0.6
pkg/reconciler/pipelinerun/resources/pipelinespec.go	Do not exist	100.0%

tekton-robot · 2019-09-20T23:44:59Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/pipeline_types.go	Do not exist	0.0%
pkg/apis/pipeline/v1alpha1/pipelinerun_validation.go	92.9%	89.5%	-3.4
pkg/reconciler/pipelinerun/pipelinerun.go	82.4%	82.9%	0.5
pkg/reconciler/pipelinerun/resources/pipelinespec.go	Do not exist	100.0%

pritidesai · 2019-09-21T00:10:35Z

/retest

pkg/reconciler/pipelinerun/pipelinerun.go

pkg/reconciler/pipelinerun/resources/pipelinespec.go

ghost · 2019-09-23T13:31:12Z

/lgtm

tekton-robot · 2019-09-23T18:57:39Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/pipeline_types.go	Do not exist	0.0%
pkg/apis/pipeline/v1alpha1/pipelinerun_validation.go	92.9%	89.5%	-3.4
pkg/reconciler/pipelinerun/pipelinerun.go	82.4%	82.9%	0.5
pkg/reconciler/pipelinerun/resources/pipelinespec.go	Do not exist	100.0%

ghost · 2019-09-23T19:00:30Z

/lgtm

ghost · 2019-09-24T16:34:41Z

/hold

I've added this as an agenda item to discuss during tomorrow's Working Group meeting. I think it would be useful to raise the profile of this change a little bit just to make sure that everyone is aware of the change and its meaning prior to merge.

pritidesai · 2019-09-25T00:10:09Z

/hold

I've added this as an agenda item to discuss during tomorrow's Working Group meeting. I think it would be useful to raise the profile of this change a little bit just to make sure that everyone is aware of the change and its meaning prior to merge.

hey @sbwsg, have created a doc here, let me know if you want to add anything specific (still editing).

ghost · 2019-09-25T11:36:15Z

@pritidesai This is perfect, thankyou. I've added links to this design doc to the WG agenda so people can review before and during the meeting.

tekton-robot · 2019-09-25T17:26:15Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/pipeline_types.go	Do not exist	0.0%
pkg/apis/pipeline/v1alpha1/pipelinerun_validation.go	92.9%	89.5%	-3.4
pkg/reconciler/pipelinerun/pipelinerun.go	82.4%	82.9%	0.5
pkg/reconciler/pipelinerun/resources/pipelinespec.go	Do not exist	100.0%

tekton-robot · 2019-09-25T17:30:55Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/pipeline_types.go	Do not exist	0.0%
pkg/apis/pipeline/v1alpha1/pipelinerun_validation.go	92.9%	89.5%	-3.4

tekton-robot · 2019-09-25T17:35:23Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/pipeline_types.go	Do not exist	0.0%
pkg/apis/pipeline/v1alpha1/pipelinerun_validation.go	92.9%	89.5%	-3.4
pkg/reconciler/pipelinerun/pipelinerun.go	82.4%	82.9%	0.5
pkg/reconciler/pipelinerun/resources/pipelinespec.go	Do not exist	100.0%

ghost · 2019-09-25T18:00:07Z

/lgtm

Its now possible to embed the whole pipeline specification into Pipeline Run using pipelineSpec, for example: apiVersion: tekton.dev/v1alpha1 kind: PipelineRun metadata: name: pipelinerun-echo-greetings spec: pipelineRef: name: pipeline-echo-greetings Can be specified as: apiVersion: tekton.dev/v1alpha1 kind: PipelineRun metadata: name: pipelinerun-echo-greetings spec: pipelineSpec: tasks: - name: echo-good-morning ... params: ...

tekton-robot · 2019-10-02T00:21:02Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/pipeline_types.go	Do not exist	0.0%
pkg/apis/pipeline/v1alpha1/pipelinerun_validation.go	92.9%	89.5%	-3.4
pkg/reconciler/pipelinerun/pipelinerun.go	82.6%	83.1%	0.5
pkg/reconciler/pipelinerun/resources/pipelinespec.go	Do not exist	100.0%

ghost · 2019-10-02T12:48:08Z

/lgtm

I guess the hold label can be cancelled now that we've discussed this in the working group meeting? @pritidesai want me to remove it?

vdemeester

/lgtm
/hold cancel

tekton-robot · 2019-10-02T14:01:30Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pritidesai, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Sep 19, 2019

tekton-robot requested review from dlorenc and a user September 19, 2019 17:43

tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 19, 2019

tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 19, 2019

ghost reviewed Sep 19, 2019

View reviewed changes

docs/pipelineruns.md Outdated Show resolved Hide resolved

pkg/apis/pipeline/v1alpha1/pipelinerun_types.go Show resolved Hide resolved

pritidesai force-pushed the pipelinespec branch from a255618 to 428cfbe Compare September 20, 2019 05:37

tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 20, 2019

tekton-robot assigned pritidesai Sep 20, 2019

pritidesai force-pushed the pipelinespec branch from 428cfbe to 67f4ba4 Compare September 20, 2019 06:10

pritidesai force-pushed the pipelinespec branch from 67f4ba4 to 94a02f7 Compare September 20, 2019 06:17

pritidesai force-pushed the pipelinespec branch from 94a02f7 to b99ed86 Compare September 20, 2019 23:43

ghost reviewed Sep 23, 2019

View reviewed changes

pkg/reconciler/pipelinerun/pipelinerun.go Outdated Show resolved Hide resolved

pkg/reconciler/pipelinerun/resources/pipelinespec.go Outdated Show resolved Hide resolved

tekton-robot assigned ghost Sep 23, 2019

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2019

pritidesai force-pushed the pipelinespec branch from b99ed86 to 3788230 Compare September 23, 2019 18:55

tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2019

vdemeester added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Sep 24, 2019

tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 24, 2019

tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2019

pritidesai force-pushed the pipelinespec branch from c5ece91 to f7de620 Compare September 25, 2019 17:28

pritidesai force-pushed the pipelinespec branch from f7de620 to f1f33f7 Compare September 25, 2019 17:32

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2019

pritidesai mentioned this pull request Sep 26, 2019

Allow embedding specs in Pipeline and PipelineRun instead of referencing. #872

Closed

pritidesai force-pushed the pipelinespec branch from f1f33f7 to 9591202 Compare October 2, 2019 00:18

tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 2, 2019

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2019

vdemeester approved these changes Oct 2, 2019

View reviewed changes

tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 2, 2019

tekton-robot assigned vdemeester Oct 2, 2019

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2019

tekton-robot merged commit b338e40 into tektoncd:master Oct 2, 2019

vdemeester mentioned this pull request Oct 23, 2019

Describe task does not work for inline task spec tektoncd/cli#380

Closed

ckadner mentioned this pull request Jun 5, 2020

Add metadata to PipelineTask to specific additional labels and annotations #2767

Closed

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding support to enable pipelineSpec #1333

Adding support to enable pipelineSpec #1333

pritidesai commented Sep 19, 2019 •

edited

Loading

tekton-robot commented Sep 19, 2019

tekton-robot commented Sep 20, 2019

pritidesai commented Sep 20, 2019

pritidesai commented Sep 20, 2019

tekton-robot commented Sep 20, 2019

tekton-robot commented Sep 20, 2019

tekton-robot commented Sep 20, 2019

tekton-robot commented Sep 20, 2019

pritidesai commented Sep 21, 2019

ghost commented Sep 23, 2019

tekton-robot commented Sep 23, 2019

ghost commented Sep 23, 2019

ghost commented Sep 24, 2019

pritidesai commented Sep 25, 2019

ghost commented Sep 25, 2019

tekton-robot commented Sep 25, 2019

tekton-robot commented Sep 25, 2019

tekton-robot commented Sep 25, 2019

ghost commented Sep 25, 2019

tekton-robot commented Oct 2, 2019

ghost commented Oct 2, 2019

vdemeester left a comment

tekton-robot commented Oct 2, 2019

Adding support to enable pipelineSpec #1333

Adding support to enable pipelineSpec #1333

Conversation

pritidesai commented Sep 19, 2019 • edited Loading

Changes

Submitter Checklist

Reviewer Notes

Release Notes

tekton-robot commented Sep 19, 2019

tekton-robot commented Sep 20, 2019

pritidesai commented Sep 20, 2019

pritidesai commented Sep 20, 2019

tekton-robot commented Sep 20, 2019

tekton-robot commented Sep 20, 2019

tekton-robot commented Sep 20, 2019

tekton-robot commented Sep 20, 2019

pritidesai commented Sep 21, 2019

ghost commented Sep 23, 2019

tekton-robot commented Sep 23, 2019

ghost commented Sep 23, 2019

ghost commented Sep 24, 2019

pritidesai commented Sep 25, 2019

ghost commented Sep 25, 2019

tekton-robot commented Sep 25, 2019

tekton-robot commented Sep 25, 2019

tekton-robot commented Sep 25, 2019

ghost commented Sep 25, 2019

tekton-robot commented Oct 2, 2019

ghost commented Oct 2, 2019

vdemeester left a comment

Choose a reason for hiding this comment

tekton-robot commented Oct 2, 2019

pritidesai commented Sep 19, 2019 •

edited

Loading