Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused results field from pr and tr specs #1425

Merged
merged 1 commit into from
Oct 15, 2019

Conversation

dibyom
Copy link
Member

@dibyom dibyom commented Oct 14, 2019

Changes

Fixes #1243
The results field is unused, was deprecated in 0.7, and was
scheduled to be removed in the 0.8 release

Co-authored-by: Daniel Helfand dhelfand@redhat.com
Signed-off-by: Dibyo Mukherjee dibyo@google.com

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Release Notes

The `results` field has been removed from the TaskRun and PipelineRun spec

The `results` field is unused, was deprecated in 0.7, and was
scheduled to be removed in the 0.8 release

Co-authored-by: Daniel Helfand <dhelfand@redhat.com>
Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 14, 2019
@ghost
Copy link

ghost commented Oct 14, 2019

/lgtm

@tekton-robot tekton-robot assigned ghost Oct 14, 2019
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2019
@tekton-robot
Copy link
Collaborator

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1alpha1/pipelineresource_validation.go 89.4% 88.7% -0.7
pkg/apis/pipeline/v1alpha1/pipelinerun_validation.go 89.5% 93.8% 4.3
pkg/apis/pipeline/v1alpha1/taskrun_validation.go 91.3% 95.3% 4.0
pkg/reconciler/pipelinerun/pipelinerun.go 82.7% 82.6% -0.1

@dibyom dibyom added cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit and removed cla: no labels Oct 14, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@dibyom
Copy link
Member Author

dibyom commented Oct 14, 2019

Daniel has previously committed to pipelines so I'm guessing its the co-authorship that messed up the CLA

@dlorenc
Copy link
Contributor

dlorenc commented Oct 15, 2019

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlorenc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2019
@tekton-robot tekton-robot merged commit 416e3b3 into tektoncd:master Oct 15, 2019
@danielhelfand
Copy link
Member

@dibyom Thanks for the co-authorship!

@dibyom dibyom deleted the results_remove branch October 25, 2019 14:48
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unused Results field
5 participants