Remove unused results field from pr and tr specs

pkg/apis/pipeline/v1alpha1/pipelineresource_validation.go

@@ -18,6 +18,7 @@ package v1alpha1
 
 import (
 	"context"
+	"net/url"
 	"strconv"
 	"strings"
 
@@ -117,3 +118,14 @@ func AllowedStorageType(gotType string) bool {
 	}
 	return false
 }
+
+func validateURL(u, path string) *apis.FieldError {
+	if u == "" {
+		return nil
+	}
+	_, err := url.ParseRequestURI(u)
+	if err != nil {
+		return apis.ErrInvalidValue(u, path)
+	}
+	return nil
+}

pkg/apis/pipeline/v1alpha1/pipelinerun_types.go

@@ -64,11 +64,6 @@ type PipelineRunSpec struct {
 	DeprecatedServiceAccounts []DeprecatedPipelineRunSpecServiceAccount `json:"serviceAccounts,omitempty"`
 	// +optional
 	ServiceAccountNames []PipelineRunSpecServiceAccountName `json:"serviceAccountNames,omitempty"`
-	// Deprecation Notice: The field Results will be removed in v0.8.0
-	// and should not be used. Plan to have this field removed before upgradring
-	// to v0.8.0.
-	// +optional
-	Results *Results `json:"results,omitempty"`
 	// Used for cancelling a pipelinerun (and maybe more later on)
 	// +optional
 	Status PipelineRunSpecStatus `json:"status,omitempty"`
@@ -113,12 +108,6 @@ type PipelineRef struct {
 type PipelineRunStatus struct {
 	duckv1beta1.Status `json:",inline"`
 
-	// Deprecation Notice: The field Results will be removed in v0.8.0
-	// and should not be used. Plan to have this field removed before upgradring
-	// to v0.8.0.
-	// +optional
-	Results *Results `json:"results,omitempty"`
-
 	// StartTime is the time the PipelineRun is actually started.
 	// +optional
 	StartTime *metav1.Time `json:"startTime,omitempty"`

pkg/apis/pipeline/v1alpha1/pipelinerun_validation.go

@@ -55,13 +55,6 @@ func (ps *PipelineRunSpec) Validate(ctx context.Context) *apis.FieldError {
 		}
 	}
 
-	// check for results
-	if ps.Results != nil {
-		if err := ps.Results.Validate(ctx, "spec.results"); err != nil {
-			return err
-		}
-	}
-
 	if ps.Timeout != nil {
 		// timeout should be a valid duration of at least 0.
 		if ps.Timeout.Duration < 0 {

pkg/apis/pipeline/v1alpha1/pipelinerun_validation_test.go

@@ -106,10 +106,6 @@ func TestPipelineRun_Validate(t *testing.T) {
 					PipelineRef: v1alpha1.PipelineRef{
 						Name: "prname",
 					},
-					Results: &v1alpha1.Results{
-						URL:  "http://www.google.com",
-						Type: "gcs",
-					},
 				},
 			},
 		}, {

pkg/apis/pipeline/v1alpha1/taskrun_types.go

@@ -36,11 +36,6 @@ type TaskRunSpec struct {
 	Inputs TaskRunInputs `json:"inputs,omitempty"`
 	// +optional
 	Outputs TaskRunOutputs `json:"outputs,omitempty"`
-	// Deprecation Notice: The field Results will be removed in v0.8.0
-	// and should not be used. Plan to have this field removed before upgradring
-	// to v0.8.0.
-	// +optional
-	Results *Results `json:"results,omitempty"`
 	// +optional
 	ServiceAccountName string `json:"serviceAccountName"`
 	// DeprecatedServiceAccount is a depreciated alias for ServiceAccountName.
@@ -105,12 +100,6 @@ var taskRunCondSet = apis.NewBatchConditionSet()
 type TaskRunStatus struct {
 	duckv1beta1.Status `json:",inline"`
 
-	// Deprecation Notice: The field Results will be removed in v0.8.0
-	// and should not be used. Plan to have this field removed before upgradring
-	// to v0.8.0.
-	// +optional
-	Results *Results `json:"results,omitempty"`
-
 	// PodName is the name of the pod responsible for executing this task's steps.
 	PodName string `json:"podName"`
 

pkg/apis/pipeline/v1alpha1/taskrun_validation.go

@@ -66,13 +66,6 @@ func (ts *TaskRunSpec) Validate(ctx context.Context) *apis.FieldError {
 		return err
 	}
 
-	// check for results
-	if ts.Results != nil {
-		if err := ts.Results.Validate(ctx, "spec.results"); err != nil {
-			return err
-		}
-	}
-
 	if ts.Timeout != nil {
 		// timeout should be a valid duration of at least 0.
 		if ts.Timeout.Duration < 0 {

pkg/reconciler/pipelinerun/pipelinerun.go

@@ -543,7 +543,6 @@ func addRetryHistory(tr *v1alpha1.TaskRun) {
 func clearStatus(tr *v1alpha1.TaskRun) {
 	tr.Status.StartTime = nil
 	tr.Status.CompletionTime = nil
-	tr.Status.Results = nil
 	tr.Status.PodName = ""
 }