Fix e2e yaml false success report #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
do-not-merge/work-in-progress
googlebot
added
the
cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
approved
vdemeester
force-pushed
the
fix-yaml-report
branch
from
830a169
to
f905931
Compare
|
(this should fail right now.. it does not 😅 ) |
vdemeester
force-pushed
the
fix-yaml-report
branch
2 times, most recently
from
5d5e4c9
to
e222c62
Compare
tekton-robot
added
size/S
Even if a `TaskRun`, or a `PipelineRun` fails, the script will return an exit code 0, which will show in CI as success. This fixes that. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
vdemeester
force-pushed
the
fix-yaml-report
branch
from
e222c62
to
ba35c2b
Compare
|
Yay! Failure! =) |
|
This should be green once #804 is in 👼 |
|
Well, let's do something about that. =) |
|
/test integration |
|
/test pull-tekton-pipeline-integration-tests whoops wrong message |
vdemeester
changed the title
tekton-robot
removed
the
do-not-merge/work-in-progress
|
@abayer @bobcatfish ready to be merged 👼 |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Even if a
TaskRun, or aPipelineRunfails, the script will returnan exit code 0, which will show in CI as success. This fixes that.
Signed-off-by: Vincent Demeester vdemeest@redhat.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.