Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pull_request_template.md #1580

Merged
merged 1 commit into from
May 10, 2023
Merged

Update pull_request_template.md #1580

merged 1 commit into from
May 10, 2023

Conversation

dibyom
Copy link
Member

@dibyom dibyom commented Apr 19, 2023

Changes

Updates our pull_request_template to match that of pipeline's. Adds some additional checks for adding kind label etc.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

/kind misc

@dibyom
Update pull_request_template.md
025fcf5 
Updates our pull_request_template to match that of pipeline's. Adds some additional checks for adding kind label etc.
@tekton-robot tekton-robot added kind/misc Categorizes issue or PR as a miscellaneuous one. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 19, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 19, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: dibyom / name: Dibyo Mukherjee (025fcf5)

@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 19, 2023
khrm
khrm reviewed Apr 19, 2023
View reviewed changes
Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2023
@khrm
Copy link
Contributor

khrm commented Apr 19, 2023

/easy-cla

@khrm
Copy link
Contributor

khrm commented Apr 19, 2023

Closing and reopening to fix cla issue.

@khrm khrm closed this Apr 19, 2023
@khrm khrm reopened this Apr 19, 2023
@WillsonHG
Copy link

/easycla

1 similar comment
@jarias-lfx
Copy link

/easycla

@afrittoli afrittoli closed this Apr 20, 2023
@afrittoli afrittoli reopened this Apr 20, 2023
khrm
khrm reviewed May 10, 2023
View reviewed changes
Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khrm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2023
@tekton-robot tekton-robot merged commit b185d03 into main May 10, 2023
@khrm khrm deleted the dibyom-patch-1 branch August 23, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khrm khrm khrm left review comments

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

Assignees

@khrm khrm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dibyom @khrm @WillsonHG @jarias-lfx @tekton-robot @afrittoli