metrics: don't increment objstore_bucket_operation_failures_total if context cancelled while reading
#117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskorn
changed the title
objstore_bucket_operation_failures_total if context cancelled while readingobjstore_bucket_operation_failures_total if context cancelled while reading
Signed-off-by: Charles Korn <charles.korn@grafana.com>
Signed-off-by: Charles Korn <charles.korn@grafana.com>
Signed-off-by: Charles Korn <charles.korn@grafana.com>
Signed-off-by: Charles Korn <charles.korn@grafana.com>
charleskorn
force-pushed
the
cancellation-during-read-is-not-an-error
branch
from
b92b4ef
to
374a7dc
Compare
Yes. However, cancelled context is currently treated as a special case everywhere else that checks for expected errors (eg. here and here), so this PR makes reading an object consistent with that. We could remove all the special checks for context cancellation, but that would then be a change in current behaviour for all consumers of this library. |
pracucci
approved these changes
May 2, 2024
Signed-off-by: Charles Korn <charles.korn@grafana.com>
fpetkovski
approved these changes
May 6, 2024
1 task
2 tasks
|
Isn't this actually hiding an error? If the initial s3 read that we do to check for 404 fails because of connection issue we don't get timing or error metrics |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR fixes an issue where the
objstore_bucket_operation_failures_totalmetric is incremented if the context is cancelled while reading an object from a bucket but after theGetorGetRangemethod has returned.This makes the behaviour consistent with other operations, and makes the behaviour consistent with a cancellation that occurs while
GetorGetRangeis executing.Verification
I have added unit tests to cover this scenario.