Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics: don't increment objstore_bucket_operation_failures_total if context cancelled while reading #117

Merged
merged 5 commits into from
May 6, 2024
Merged

metrics: don't increment objstore_bucket_operation_failures_total if context cancelled while reading #117

merged 5 commits into from
May 6, 2024

Commits on May 1, 2024

  1. Add tests for existing behaviour. 

    Signed-off-by: Charles Korn <charles.korn@grafana.com>
    @charleskorn
    charleskorn committed May 1, 2024
    Configuration menu
    Copy the full SHA
    e56e6f1 View commit details
    Browse the repository at this point in the history

  2. Add failing test 

    Signed-off-by: Charles Korn <charles.korn@grafana.com>
    @charleskorn
    charleskorn committed May 1, 2024
    Configuration menu
    Copy the full SHA
    f1ab9d8 View commit details
    Browse the repository at this point in the history

  3. Add fix for issue. 

    Signed-off-by: Charles Korn <charles.korn@grafana.com>
    @charleskorn
    charleskorn committed May 1, 2024
    Configuration menu
    Copy the full SHA
    88acb32 View commit details
    Browse the repository at this point in the history

  4. Add changelog entry. 

    Signed-off-by: Charles Korn <charles.korn@grafana.com>
    @charleskorn
    charleskorn committed May 1, 2024
    Configuration menu
    Copy the full SHA
    374a7dc View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Don't pass context to timingReader 

    Signed-off-by: Charles Korn <charles.korn@grafana.com>
    @charleskorn
    charleskorn committed May 6, 2024
    Configuration menu
    Copy the full SHA
    d44110f View commit details
    Browse the repository at this point in the history