Skip to content

Commit

Permalink
compact: remove cancel on SyncMetas errors (#5923)
Browse files Browse the repository at this point in the history
in a favour of 86b4039 SyncMetas will retry if it's retriable.
Also, the cleanPartialMarked calls are surrounded by runutil.Repeat() will be repeated,
the ones not and are not retriable will throw an interrupt to run.Group() by returning err
and Group will call cancel() as it's configured for its interrupt func.

Signed-off-by: Seena Fallah <seenafallah@gmail.com>

Signed-off-by: Seena Fallah <seenafallah@gmail.com>
  • Loading branch information
clwluvw committed Dec 21, 2022
1 parent 5761afb commit 6e71787
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion cmd/thanos/compact.go
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,6 @@ func runCompact(
defer cleanMtx.Unlock()

if err := sy.SyncMetas(ctx); err != nil {
cancel()
return errors.Wrap(err, "syncing metas")
}

Expand Down

0 comments on commit 6e71787

Please sign in to comment.