compact: remove cancel on SyncMetas errors

[clwluvw]

Changes

A follow-up on #5922
In a favour of 86b4039 SyncMetas will retry if it's retriable.
Also, the cleanPartialMarked calls are surrounded by runutil.Repeat() will be repeated,
the ones not and are not retriable will throw an interrupt to run.Group() by returning err
and Group will call cancel() as it's configured for its interrupt func.

Signed-off-by: Seena Fallah seenafallah@gmail.com

[fpetkovski]

is cleanPartialMarked used somewhere else? And should we call cancel for non-retryable errors now?

[clwluvw]

is cleanPartialMarked used somewhere else? And should we call cancel for non-retryable errors now?

I think I need to edit my commit message, cleanPartialMarked is basically returning err but the ones surrounded by Repeat will return nil if it was a retriable error.
And by returning err on non-repeated scenarios (like !wait) and non-retriable errors, it will call the cancel in a favour of run.Group interrupt function:

}, func(error) {
	cancel()
})

[fpetkovski]

This makes sense to me, but maybe someone with more knowledge around the compactor can take a look.

[clwluvw]

This makes sense to me, but maybe someone with more knowledge around the compactor can take a look.

@fpetkovski Can you request a review or mention them?

[clwluvw]

@bwplotka @GiedriusS Can you take a look, please?

[clwluvw]

ping @GiedriusS @bwplotka

[clwluvw]

@GiedriusS @bwplotka As a part of this change has been merged into master - if this doesn't come with that release, I think we will going to have a broken release for this part of the change. Can you please take a look before the new release?

Indeed it will leads to have non-healthy probs with reason=null

[bwplotka]

Agree, can you base that PR to merge to release-0.30 branch please?

[clwluvw]

Agree, can you base that PR to merge to release-0.30 branch please?

@bwplotka I can cherry-pick the commit. But I think it needs to be on the master branch as well, shouldn't it?

[bwplotka]

We merge release branch to master later on, so all good. I changed the base branch

[bwplotka]

Thanks!

[clwluvw]

@bwplotka Just out of curiosity, when will you merge that to the main branch?:)

[GiedriusS]

@clwluvw I'll merge this into main today 😄