Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate new improvements from upstream in the React UI #3541

Closed
6 of 8 tasks
onprem opened this issue Dec 5, 2020 · 14 comments · Fixed by #3676
Closed
6 of 8 tasks

Incorporate new improvements from upstream in the React UI #3541

onprem opened this issue Dec 5, 2020 · 14 comments · Fixed by #3676

Comments

@onprem
Copy link
Member

onprem commented Dec 5, 2020

In past few months there have been a sizable amount of UI related improvemnts in the upstream Prometheus code. A lot of those improvements make sense for Thanos as well.

Here's a list of PRs (in no specific order) that I think we should take a look at:

Most of these are pretty straightforward and small changes and should be easy for first time contributors.

@subhangi2731
Copy link

can you assign this issue to me @prmsrswt

@onprem
Copy link
Member Author

onprem commented Dec 7, 2020

@subhangi2731 There are a lot of small tasks here, so you can pick something you'd like to work on and just comment here that you are working on it. That'll be sufficient to reduce duplicate efforts imo.

@Namanl2001
Copy link
Contributor

Namanl2001 commented Dec 27, 2020

@prmsrswt I'll open a PR for
Fix styling bug for target labels with special names
Remove the need of pathPrefix in the React UI.
Fix react UI bug with series going on and off.
Fix button display when there is no panels soon.

@ajinkya359
Copy link
Contributor

@prmsrswt I will work on the issue
fix detail swatch glitch

@ajinkya359
Copy link
Contributor

I will open a PR for Support new duration format in graph range input

@yeya24
Copy link
Contributor

yeya24 commented Dec 28, 2020

This was closed by accident. Reopen it now.

@yeya24
Copy link
Contributor

yeya24 commented Apr 2, 2021

We also want to add the new editor. Should we add it here or open another issue?

@stale
Copy link

stale bot commented Jun 2, 2021

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale
Copy link

stale bot commented Aug 3, 2021

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Aug 3, 2021
@stale
Copy link

stale bot commented Aug 17, 2021

Closing for now as promised, let us know if you need this to be reopened! 🤗

@stale stale bot closed this as completed Aug 17, 2021
@yeya24 yeya24 reopened this Aug 17, 2021
@stale stale bot removed the stale label Aug 17, 2021
@stale
Copy link

stale bot commented Oct 30, 2021

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Oct 30, 2021
@Namanl2001
Copy link
Contributor

still valid

@stale stale bot removed the stale label Oct 30, 2021
@stale
Copy link

stale bot commented Jan 9, 2022

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Jan 9, 2022
@stale
Copy link

stale bot commented Mar 2, 2022

Closing for now as promised, let us know if you need this to be reopened! 🤗

@stale stale bot closed this as completed Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants