Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix detail swatch glitch #3676

Merged
merged 4 commits into from
Dec 28, 2020
Merged

Fix detail swatch glitch #3676

merged 4 commits into from
Dec 28, 2020

Conversation

ajinkya359
Copy link
Contributor

Fixes #3541
Subissue = Fix detail swatch glitch

Changes

Properly closed span tag in pkg/ui/react-app/src/pages/graph/GraphHelpers.ts and pkg/ui/react-app/src/pages/graph/GraphHelpers.test.ts

Bumped up jquery and @types/jquey

@ajinkya359
Bumping up jquery and @types/jquery
4df6fdb 
Signed-off-by: ajinkya359 <sajinkya359@gmail.com>
@ajinkya359
properly close the span tag in
2f744a9 
Signed-off-by: ajinkya359 <sajinkya359@gmail.com>
@ajinkya359
properly close the span tag in GraphHelpers.test.ts and GraphHelpers.ts
acc3ed0 
Signed-off-by: ajinkya359 <sajinkya359@gmail.com>
@ajinkya359
make assets
1cc9862 
Signed-off-by: ajinkya359 <sajinkya359@gmail.com>
bwplotka
bwplotka approved these changes Dec 28, 2020
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing to me (: LGTM

@bwplotka
Copy link
Member

Thanks!

@bwplotka bwplotka merged commit f26b491 into thanos-io:master Dec 28, 2020
@ajinkya359 ajinkya359 deleted the fix_detail_swatch_glitch branch December 28, 2020 17:56
@onprem onprem mentioned this pull request Feb 18, 2021
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwplotka bwplotka bwplotka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorporate new improvements from upstream in the React UI
2 participants
@ajinkya359 @bwplotka