Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing Metrics AutoComplete to AutoComplete #3564

Conversation

khyatisoneji
Copy link
Contributor

Signed-off-by: Khyati Soneji khyatisoneji5@gmail.com

Signed-off-by: Khyatisoneji <khyatisoneji5@gmail.com>
@khyatisoneji khyatisoneji force-pushed the ChangeMetricAutoCompleteToAutoComplete branch from 86d2336 to 4b07d76 Compare December 10, 2020 18:12
Signed-off-by: Ben Ye <yb532204897@gmail.com>
Signed-off-by: Khyatisoneji <khyatisoneji5@gmail.com>
@khyatisoneji khyatisoneji force-pushed the ChangeMetricAutoCompleteToAutoComplete branch from 7ce6f14 to 037fb0d Compare December 10, 2020 18:33
This reverts commit 037fb0d.

Signed-off-by: Khyatisoneji <khyatisoneji5@gmail.com>
@khyatisoneji khyatisoneji force-pushed the ChangeMetricAutoCompleteToAutoComplete branch from 6fd7bd2 to 55a195c Compare December 10, 2020 18:48
@khyatisoneji khyatisoneji changed the title Adapting to multierrors or tsdb_errors from prometheus Changing Metrics AutoComplete to AutoComplete Dec 10, 2020
Copy link
Member

@onprem onprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some minor nits. You need to run make assets as well :)

pkg/ui/react-app/src/pages/graph/PanelList.tsx Outdated Show resolved Hide resolved
pkg/ui/react-app/src/pages/graph/PanelList.tsx Outdated Show resolved Hide resolved
Signed-off-by: Khyatisoneji <khyatisoneji5@gmail.com>
@khyatisoneji khyatisoneji force-pushed the ChangeMetricAutoCompleteToAutoComplete branch from ce4f138 to 76a4322 Compare December 11, 2020 16:09
bwplotka and others added 2 commits December 11, 2020 22:32
* storegw: Optimized inject label stage of index lookup.

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>

* Improved helper method instead.

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>

* Updated busybox pin.

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Signed-off-by: Khyatisoneji <khyatisoneji5@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants