Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/receive: register handler metrics #1261

Merged
merged 1 commit into from
Jun 19, 2019

Conversation

squat
Copy link
Member

@squat squat commented Jun 19, 2019

The thanos receive component instruments its handler with some metrics
but these metrics are currently never registered.

Changes

Register the receive handler metrics with the given registerer during creation.

Verification

Scrape the receive component's /metrics endpoint to verify that the handler metrics are now present.

cc @brancz @bwplotka

The thanos receive component instruments its handler with some metrics
but these metrics are currently never registered.
@brancz
Copy link
Member

brancz commented Jun 19, 2019

Oh my. Second time in two days. Someone really should invest in some static tooling to try to catch common mistakes like this.

lgtm 👍

@brancz brancz merged commit b3256e0 into thanos-io:master Jun 19, 2019
@brancz
Copy link
Member

brancz commented Jun 19, 2019

As a side note, but should be done in a separate PR .. we probably want metrics for requests total

@squat squat deleted the registerhandlermetrics branch June 19, 2019 15:50
squat added a commit to squat/thanos that referenced this pull request Jun 19, 2019
As per the discussion in
thanos-io#1261 (comment),
let's add a metric to track the total number of requests handled by the
receive component.
brancz pushed a commit that referenced this pull request Jun 19, 2019
As per the discussion in
#1261 (comment),
let's add a metric to track the total number of requests handled by the
receive component.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants