Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/receive: add requests counter metric #1262

Merged
merged 1 commit into from
Jun 19, 2019

Conversation

squat
Copy link
Member

@squat squat commented Jun 19, 2019

As per the discussion in
#1261 (comment),
let's add a metric to track the total number of requests handled by the
receive component.

Changes

Add a thanos_http_requests_total metric to the receive component.

Verification

  • start thanos receive
  • make a request against the receive endpoint; and
  • verify that the counter is increased

cc @brancz @bwplotka

As per the discussion in
thanos-io#1261 (comment),
let's add a metric to track the total number of requests handled by the
receive component.
@brancz brancz merged commit 24dd615 into thanos-io:master Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants