Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ForemanLeapp plugin #502

Merged
merged 4 commits into from
May 4, 2020
Merged

Add ForemanLeapp plugin #502

merged 4 commits into from
May 4, 2020

Conversation

stejskalleos
Copy link
Contributor

No description provided.

@ehelms
Copy link
Member

ehelms commented Apr 30, 2020

Howdy @stejskalleos , you'll want to add this to katello-answers.yaml as well. And create a migration to ensure ugprades have this available. There is a helper in bin/ to help with this.

@ekohl
Copy link
Member

ekohl commented Apr 30, 2020

The tests will also fail until theforeman/puppet-foreman#833 is merged.

@stejskalleos
Copy link
Contributor Author

Updated katello-answers.yaml and rebased.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed the katello migration. Note the naming conventions are slightly different for the two, but the create-migration script takes care of it. You can even echo the actual migration to stdin to ensure the content is the same.

@ekohl
Copy link
Member

ekohl commented May 4, 2020

@ekohl ekohl merged commit bb98096 into theforeman:develop May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants