Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Leapp plugin #833

Merged
merged 2 commits into from
Apr 30, 2020
Merged

Add Leapp plugin #833

merged 2 commits into from
Apr 30, 2020

Conversation

stejskalleos
Copy link
Contributor

No description provided.

ekohl
ekohl requested changes Apr 30, 2020
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ubuntu is sometimes failing on a timing issue. Maybe it needs to use systemd notify support so it's really started when systemctl start finishes, rather than still initializing.

manifests/plugin/leapp.pp Outdated Show resolved Hide resolved
@stejskalleos @ekohl
Update manifests/plugin/leapp.pp
c6562e1 
Co-authored-by: Ewoud Kohl van Wijngaarden <ewoud@kohlvanwijngaarden.nl>
@ekohl ekohl mentioned this pull request Apr 30, 2020
Merged
@ekohl ekohl merged commit 1f47719 into theforeman:master Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stejskalleos @ekohl @theforeman-bot @wbclark