-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump ntapi to 0.4 to get rid of rejected code #1707
Conversation
I'm not sure this will work with our MSRV, but the CI will tell us. |
I am not sure I understand this output correctly, but it seems that Maybe it needs to be pinned to EditI did some additional digging and it seems |
Yes, this is resolved in #1673, also see #1666. I think we need to add |
@FrankenApps can you rebase this on the v0.7.x branch? I've expanded to MSRV check of the CI to include Windows. |
6fe4227
to
00d0f1a
Compare
@Thomasdezeeuw Done. Thanks for getting all that other stuff in. |
Ah see I was afraid of that ntapi v0.4 doesn't work with rustc 1.46. So, now we have a bit of a problem. Newer versions of rustc can't compile ntapi v0.3, but older versions can't compile v0.4... |
If you don't want to bump the MSRV of v0.7, then you could vendor the parts of ntapi you need. It's not very much:
|
Or we can fix ntapi v0.3? |
What is the strategy going to be here? If there is a chance to bump the MSRV for 0.7.x it would probably be the easiest solution. Otherwise I can take a shot at vendoring the needed parts. |
Except that's a breaking chance, more or less, there is plenty of discussion around this.
I think we have the following options:
|
I think vendoring is worth a shot. |
I implemented the relevant code from |
ntapi
version0.3.7
cotains code which is rejected using the latest version of rust.I am unable to upgrade
mio
to0.8
at the moment so it would be great if it was possible to release another0.7.x
version with this dependency upgrade.For reference, here is the related issue in
ntapi
.