Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: make log an optional dependency #1708

Merged
merged 1 commit into from
Aug 13, 2023

Conversation

Thomasdezeeuw
Copy link
Collaborator

Currently, Mio depends on log. In rust-lang/log#552, the log maintainers aim to increase log's MSRV to 1.60. This MSRV increase would impact Mio, which in turn, would impact Tokio. As of 1.25, Tokio supports Rust 1.49 with the intent of supporting it until March 2024.

This commit makes log an optional dependency for those who wish to maintain a lower MSRV.

Backport of #1673, commit 44df449

Currently, Mio depends on `log`. In rust-lang/log#552, the `log`
maintainers aim to increase `log`'s MSRV to 1.60. This MSRV increase
would impact Mio, which in turn, would impact Tokio. As of 1.25, Tokio
supports Rust 1.49 with the intent of supporting it until March 2024.

This commit makes `log` an optional dependency for those who wish to
maintain a lower MSRV.

Backport of commit 44df449
@Thomasdezeeuw
Copy link
Collaborator Author

Our CI issues in v0.7.x are related to the Miow dependency and might be fixed by #1707.

@Thomasdezeeuw Thomasdezeeuw changed the title make log an optional dependency Backport: make log an optional dependency Aug 13, 2023
@Thomasdezeeuw Thomasdezeeuw merged commit 375294b into tokio-rs:v0.7.x Aug 13, 2023
13 of 15 checks passed
@Thomasdezeeuw Thomasdezeeuw deleted the backport_1673 branch August 13, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants