Skip to content

Commit

Permalink
fix(forms): input-group and validation icons (#32968)
Browse files Browse the repository at this point in the history
Fixes #30131

Issue mentions `form-control` but it impacts `.custom-select` — but not `textarea` since it has a qualifying type selector that increases its specificty.

So another way could be to set `select.custom-select` and `input.form-control`. Would there be any other tag concerned by those classes?

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
  • Loading branch information
ffoodd and XhmikosR committed Feb 15, 2021
1 parent 29674b8 commit 030af97
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions scss/mixins/_forms.scss
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@
border-color: $color;

@if $enable-validation-icons {
padding-right: $input-height-inner;
padding-right: $input-height-inner !important; // stylelint-disable-line declaration-no-important
background-image: escape-svg($icon);
background-repeat: no-repeat;
background-position: right $input-height-inner-quarter center;
Expand Down Expand Up @@ -114,7 +114,7 @@
border-color: $color;

@if $enable-validation-icons {
padding-right: $custom-select-feedback-icon-padding-right;
padding-right: $custom-select-feedback-icon-padding-right !important; // stylelint-disable-line declaration-no-important
background: $custom-select-background, $custom-select-bg escape-svg($icon) $custom-select-feedback-icon-position / $custom-select-feedback-icon-size no-repeat;
}

Expand Down

0 comments on commit 030af97

Please sign in to comment.