fix(forms): input-group and validation icons #32968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #30131 Issue mentions `form-control` but it impacts `.custom-select` — but not `textarea` since it has a qualifying type selector that increases its specificty. So another way could be to set `select.custom-select` and `input.form-control`. Would there be any other tag concerned by those classes?
|
Not stoked about the |
|
IMHO And I don't think we should spend time to work around this, since it's only in v4. Going further might lead to smuch more side effects. |
mdo
approved these changes
Feb 11, 2021
This was referenced May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30131
Issue mentions
.form-controlbut it also impacts.custom-select— but nottextarea(as you may see in this reduced test case) since it has a qualifying type selector that increases its specificity.So another way could be to set
select.custom-selectandinput.form-control. Would there be any other tag concerned by those classes?