-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.buckconfig has lower priority than .okbuck/config/okbuck.buckconfig #927
Comments
This should resolve the issue: https://github.com/uber/okbuck/pull/929/files (will require rerunning buckwrapper task). Meanwhile you can fix the error by manually updating buckw similar to as it is done in the above pr. |
raviagarwal7
added a commit
that referenced
this issue
Nov 10, 2020
Don't pass okbuck.buckconfig explicity to buck in the buckwrapper to allow overriding configs in .okbuck.buckconfig Bump Kotlin to 1.4.10 and incorporate Subplugin changes Bump buck to a68ef0d834eec5fe381cb3e8e8612ba9fa42a09d. The latest version has changes to kotlin params which will require further changes when updating. Resolves #927
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Okbuck plugin 0.51.2
The issue is that default kotlin_home path isn't valid for me. I suppose not only for me, because of .okbuck/workspace/koltin_home is always contained only a single BUCK file
I change kotlin_home in it .buckconfig to a valid one, but these changes are ignoring by okbuck. Only if remove kotlin_home from .okbuck/config/okbuck.buckconfig it read value from .buckconfig.
This change works ok before any changes in gradle files, because in this case, okbuck.buckconfig is regenerating.
So, I don't have the ability to specify kotlin_home location. I suppose that .buckconfig must have more priority than okbuck.buckconfig, otherwise it doesn't have a sense
The text was updated successfully, but these errors were encountered: