Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .okbuck.buckconfig to .buckconfig #929

Merged
merged 3 commits into from
Nov 10, 2020
Merged

Add .okbuck.buckconfig to .buckconfig #929

merged 3 commits into from
Nov 10, 2020

Conversation

raviagarwal7
Copy link
Collaborator

@raviagarwal7 raviagarwal7 commented Nov 9, 2020

Don't pass okbuck.buckconfig explicity to buck in the
buckwrapper to allow overriding configs in .okbuck.buckconfig

Bump Kotlin to 1.4.10 and incorporate Subplugin changes

Bump buck to a68ef0d834eec5fe381cb3e8e8612ba9fa42a09d. The latest version
has changes to kotlin params which will require further changes when updating.

Resolves #927

Copy link
Contributor

@oliviernotteghem oliviernotteghem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Don't pass .okbuck.buckconfig explicity to buck in the
buckwrapper to allow overriding configs in .okbuck.buckconfig

Invalidate gradle cache version
@raviagarwal7 raviagarwal7 merged commit 723c2e3 into master Nov 10, 2020
@raviagarwal7 raviagarwal7 deleted the ravi/fix-order branch November 10, 2020 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.buckconfig has lower priority than .okbuck/config/okbuck.buckconfig
3 participants