Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: incentive module spec #1949

Merged
merged 23 commits into from
Jun 19, 2023
Merged

docs: incentive module spec #1949

merged 23 commits into from
Jun 19, 2023

Conversation

toteki
Copy link
Member

@toteki toteki commented Mar 24, 2023

Spec for the incentive module.

I decided to create it in a separate PR so design review doesn't clutter the code review of the larger feature PR when it occurs.

Safe to merge of course, but should stay open for the duration of the module review.

@robert-zaremba
Copy link
Member

@brandoncomer could you review as well?

x/incentive/README.md Outdated Show resolved Hide resolved
x/incentive/README.md Outdated Show resolved Hide resolved
x/incentive/README.md Outdated Show resolved Hide resolved
x/incentive/README.md Outdated Show resolved Hide resolved
x/incentive/README.md Show resolved Hide resolved
x/incentive/README.md Outdated Show resolved Hide resolved
x/incentive/README.md Outdated Show resolved Hide resolved
x/incentive/README.md Outdated Show resolved Hide resolved
x/incentive/README.md Show resolved Hide resolved
x/incentive/README.md Outdated Show resolved Hide resolved
toteki and others added 5 commits March 27, 2023 15:13
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update the spec in places which were discussed to clarify the mechanism.

x/incentive/README.md Outdated Show resolved Hide resolved
x/incentive/README.md Outdated Show resolved Hide resolved
x/incentive/README.md Outdated Show resolved Hide resolved
@EbrahimElbagory EbrahimElbagory added this pull request to the merge queue Jun 19, 2023
Merged via the queue into main with commit 8e9cd5d Jun 19, 2023
20 checks passed
@EbrahimElbagory EbrahimElbagory deleted the adam/ispec branch June 19, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants