feat: finish incentive module #1952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // EndBlock executes all ABCI EndBlock logic respective to the x/incentive module. | ||
| // It returns no validator updates. | ||
| func (am AppModule) EndBlock(ctx sdk.Context, _ abci.RequestEndBlock) []abci.ValidatorUpdate { | ||
| return EndBlocker(ctx, am.keeper) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods
Codecov Report
@@ Coverage Diff @@
## main #1952 +/- ##
==========================================
- Coverage 75.38% 68.98% -6.41%
==========================================
Files 100 116 +16
Lines 8025 9453 +1428
==========================================
+ Hits 6050 6521 +471
- Misses 1589 2449 +860
- Partials 386 483 +97
|
3 tasks
robert-zaremba
approved these changes
Apr 24, 2023
There was a problem hiding this comment.
Pre - approving. Most of the issues were solved or moved to tasks. TODO, before merging:
- use community Fund, instead of custom fund
- document (proto) and add to the spec about 5 simultaneous unbonding (ideally let's change to 10)
- add a helper function: feat: finish incentive module #1952 (comment)
|
Max unbondings is already described in spec - I have added a note in proto docs about it as well. |
|
e2e passed - I'm merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains:
closes: #1749