feat: implement special asset pairs #2164
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
toteki
commented
Jul 31, 2023
Comment on lines
+146
to
+148
| func (ap *AccountPosition) BorrowedValue() sdk.Dec { | ||
| return ap.borrowedValue | ||
| } |
There was a problem hiding this comment.
Keeping all the fields on this struct private to prevent accidental misuse: this value should be immutable once the struct is initialized, so we don't expose it to be set from the keeper package (or others)
toteki
commented
Jul 31, 2023
x/leverage/types/position.go
Outdated
Comment on lines
219
to
225
| // if no borrows remain after matching, user may have additional borrow limit available | ||
| borrowLimit := ap.borrowedValue | ||
| for _, c := range remainingCollateral { | ||
| // the borrow limit calculation assumes no additional limitations based on borrow factor | ||
| borrowLimit = borrowLimit.Add(c.Asset.Amount.Mul(c.Weight)) | ||
| } | ||
| return borrowLimit |
There was a problem hiding this comment.
If the borrowed asset had a lower collateral weight than remaining collateral, the actual max borrow will be lower than is suggested here. We will have a separate helper function for MaxBorrow, or add parameters to this one to enable that calculation.
toteki
commented
Jul 31, 2023
toteki
commented
Jul 31, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Converting back to draft - the AccountPosition struct is being moved to #2178 and will be tested extensively before I resume my work here, since I've been running into some unexpected complexity. |
|
Superseded by #2178 |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 11, 2023
* isolate AccountPosition from #2164 * start test file * create wide range of position testing assets, special pairs * package change * ++ * ++ * ++fix * ++ * ++fix * ++ * ++ * ++ * ++ * ++ * ++fix * ++ * ++scenario * ++ EXAMPLES.md * fix merge * sorting of pairs breaks ties using denom (alphabetical) * maxBorrow step 1: surplus collateral * ++ * ++ * ++ * ++ * ++ * ++ * ++ * ++validate * ++ * max borrow can displace ordinary borrows * ++ * todo comments * todo comments * -- * --err * ++ * ++ * ++ * ++naive maxBorrow * ++ * ++ * ++fix * ++f * ++ * ++ * lint * ++ * ++ * ++ * ++ * ++ * ++ * ++ * ++ * ++ todo comments * ++ todo comments * sort function * ++ * misc * finish implementing MaxWithdraw * -- * apply new borrow limit to assertBorrowerHealth * switch module to new functions * move maxWithdraw and maxBorrow over * fix one price outage issue * fix another price outage issue * fix client test * ++ * ++ * ++ * ++ * ++ * ++ * ++ * finish * fix the lint and build issue * fix the tests * fix the markdown lint --------- Co-authored-by: Sai Kumar <sai@umee.cc>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extension of #2150 (second try, since the first got a little messy with merge commits from main)