feat: special asset pairs full implementation #2178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2178 +/- ##
==========================================
- Coverage 75.38% 69.18% -6.21%
==========================================
Files 100 166 +66
Lines 8025 12551 +4526
==========================================
+ Hits 6050 8683 +2633
- Misses 1589 3316 +1727
- Partials 386 552 +166
|
toteki
changed the title
toteki
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // also check collateral value vs weighted borrow (borrow factor limit) | ||
| otherCollateralValue, err := k.VisibleCollateralValue(ctx, otherCollateral, types.PriceModeLow) | ||
| if err != nil { | ||
| maxWithdraw := coin.Zero(uDenom) |
Check warning
Code scanning / CodeQL
Useless assignment to local variable Warning
gsk967
reviewed
Aug 11, 2023
gsk967
reviewed
Aug 11, 2023
gsk967
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See TODO comments in code