Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run make proto-gen #876

Closed
wants to merge 1 commit into from
Closed

chore: run make proto-gen #876

wants to merge 1 commit into from

Conversation

toteki
Copy link
Member

@toteki toteki commented May 6, 2022

Missed this as part of #870


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added appropriate labels to the PR
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@robert-zaremba
Copy link
Member

It was not missed. I said and noted ("Follow up tasks:") that I will do it in a separate PR (created today morning: #877).
We can merge yours if you prefer, but better to chat rather than duplicate the work ;)

@toteki
Copy link
Member Author

toteki commented May 9, 2022

I'll close this one and approve #877

@toteki toteki closed this May 9, 2022
@toteki toteki deleted the adam/protogen branch May 9, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants